ci(e2e): skip shards for backend, sync, and scripts-only pull requests - #3408
Merged
Conversation
The Playwright suite boots the web dev server (packages/web, which imports only packages/core) against stubbed routes; packages/backend, packages/sync, and packages/scripts are never loaded. 22% of PR e2e runs in the 2026-09 audit were on PRs touching only those packages: 200 shard jobs and 4 minutes of PR wall clock each for no signal. detect-code-changes.sh gains an e2e output next to code; the e2e-shard job gates on it. The docs-only skip, the e2e gate reporting Success on a skip, and the always-run merge_group and push behavior are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
tyler-dane
enabled auto-merge
September 5, 2026 14:46
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: no issue. Second fix from the CI audit started in #3407.
What and why
The Playwright suite boots the web dev server (
packages/web, which imports onlypackages/core) against stubbed/api/**routes. Neithere2e/,playwright.config.ts, norpackages/web/dev.tsimports frompackages/backend,packages/sync, orpackages/scripts, so a PR that touches only those packages cannot change an e2e result. In the audit window, 50 of 232 PR e2e runs (22%, across 33 PRs) were such PRs: 200 shard jobs and about 4 minutes of PR wall clock each, for no signal.detect-code-changes.shgains ane2eoutput next tocode: false when every changed file is under those three packages or is docs. Thee2e-shardjob gates on it; thee2egate already reports Success when the shards are skipped, so the required check still reports and docs-only handling is unchanged (#2938, #2940).merge_groupandpushevents still report true, so every merge is tested end to end before and after it lands onmain. The Unit workflow still reads onlycode.Tests cover: backend+sync+scripts+docs skips e2e only; backend plus any one of core, web,
e2e/,playwright.config.ts,bun.lock, or the e2e workflow runs everything; unverifiable file lists run everything; the two workflows gate on the intended outputs.Verify
The three failures are the same as in #3407:
agent-loop-next.shusesmapfile, which macOS/bin/bash3.2 lacks. Not touched by this diff; passes on the Linux runner. All 9detect-code-changestests, the other scripts tests, type-check, lint, and knip pass locally. CI on Linux is the arbiter.🤖 Generated with Claude Code