Keep 1253 activate deactivate workflow finishes#158
Merged
Conversation
joelorzet
requested review from
a team,
OleksandrUA,
eskp,
suisuss and
taitsengstock
and removed request for
a team
eskp
reviewed
Jan 20, 2026
eskp
left a comment
eskp
left a comment
There was a problem hiding this comment.
Can you please include a loom of what this looks like
eskp
previously approved these changes
Jan 21, 2026
- Updated the database schema to include workflows in the dispatcher. - Modified the query to fetch enabled schedules for both enabled workflows and schedules.
- Added a new `handleValidate` function to check for broken references, missing fields, and integrations before executing workflows. - Integrated the `WorkflowIssuesOverlay` to display validation issues with customizable action labels. - Updated the workflow toolbar to conditionally show an enable/disable switch based on the trigger type.
- Add workflow.enabled check in schedule-executor.ts to prevent execution of disabled workflows after they've been dispatched to SQS - Add workflow.enabled check in job-spawner.ts to prevent spawning k8s jobs for disabled workflows - Update deploy/local/hybrid/deploy.sh to use POSTGRES_DB from .env for worktree database name consistency - Fix api-key-auth.test.ts with proper Vitest skip mechanism and lint compliance - Fix web3-steps.test.ts by adding explorerConfigs mock to db mock
…andling Unit tests (schedule-executor.test.ts): - validates workflow is enabled before execution - allows execution when workflow is enabled - skips execution when workflow disabled after dispatch (race condition) E2E tests (full-pipeline.test.ts): - should skip execution for disabled workflow (job-spawner check) - should handle race condition: workflow disabled after dispatch but before execution - should allow execution for enabled workflow
suisuss
force-pushed
the
KEEP-1253-Activate-deactivate-Workflow-finishes
branch
from
10c7a2a to
a7a2612
Compare
- Add defense-in-depth check in workflow-runner.ts for disabled workflows - Update E2E test to verify runner cancels disabled workflow execution - Remove trivial unit tests that only tested boolean logic - Add enabled: true to test workflow inserts (schema defaults to false) - Fix unused variable and formatting in workflow-toolbar.tsx
suisuss
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overview
Added validation before enabling workflows with Schedule or Event trigger types to prevent enabling workflows with configuration issues.
Changes
updateWorkflowEnabledhelper function to reduce code duplicationImpact
Prevents enabling workflows with configuration errors, reducing runtime failures for scheduled and event-triggered workflows. Allows users to continue drafting workflows while avoiding node errors.
Evidence