fix: classify condition node misconfiguration as user error - #1859
Merged
Conversation
Condition node failures (no expression configured, invalid expression) matched no rule in the execution error classifier and fell through to the system default, so they were labeled system/workflow_engine. These are workflow-author configuration faults, so classify them as user errors and keep them out of the system-error signal used for alerting. Adds the two classifier rules and unit coverage.
joelorzet
requested review from
a team,
OleksandrUA,
eskp and
suisuss
and removed request for
a team
July 30, 2026 23:49
Contributor
🧹 PR Environment Cleaned UpThe PR environment has been successfully deleted. Deleted Resources:
All resources have been cleaned up and will no longer incur costs. |
Contributor
ℹ️ No PR Environment to Clean UpNo PR environment was found for this PR. This is expected if:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Condition node failures matched no rule in the execution error classifier (
lib/errors/classify.ts) and fell through to the system default, so they were labeledsystem/workflow_engine. Two condition messages are now matched as workflow-author configuration faults:CONFIGURATION/userVALIDATION/userWhy
Both failures are caused by the workflow author leaving a condition node unconfigured or entering an invalid expression. They are not platform faults, so they should surface as
usererrors and stay out of thesystemerror signal used for alerting.Changes
lib/errors/classify.ts.tests/unit/classify-execution-error.test.ts.