Add scene URL parameter resolver (PUL-F008)#70
Merged
Brad-Edwards merged 18 commits intodevfrom May 4, 2026
Merged
Conversation
Brad-Edwards
force-pushed
the
17-pul-f008-url-parameter-scene
branch
from
a68cc19 to
9863c72
Compare
|
This was referenced May 4, 2026
Brad-Edwards
added a commit
that referenced
this pull request
May 4, 2026
PUL-F010's runtime path (parser, dispatcher, loader) shipped with PUL-F008 (PR #70) and was reinforced for PUL-F009 by PR #72; this PR pins PUL-F010's distinctive contract — the index parameter positions playback at the zero-based composition entry — at the loader boundary so a future refactor cannot silently collapse composition-index to a head-of-manifest load, off-by-one the index, or single-load manifest[index] and drop trailing entries. Also extends ADR-013 and ADR-014 to name PUL-F010 explicitly: ADR-013 records that index is not scene identity / id alias / persistent bookmark and adds the "PUL-F010 forks from composition path" risk + mitigation; ADR-014 records that composition+index is PUL-F010's positional navigation behavior and adds the "index handling creates a second playback state machine" risk + mitigation.
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sceneURL parameter is present, theruntime parses it once at the boundary, validates the identifier
shape via the shared
isKebabIdentifierrule, resolves existencevia the scene registry, and surfaces malformed/unknown ids as
navigation errors before any lifecycle hook runs.
src/runtime/url-navigation.tswithresolveSceneNavigationTarget(pure parser →
SceneNavigationTarget | null) andloadSceneNavigationTarget(lifecycle bridge that reusesresolveCompositionso the URL path inherits PUL-F004's preload →create → timeline → cleanup ordering and PUL-F006's
mandatory-cleanup invariant).
it in the ADR index and builds the runtime to its constraints) and
a 43-test Vitest spec covering every PUL-F008 clause and ADR-013
guardrail (input shapes, scene-absent → null, repeated-parameter
rejection, malformed-shape rejection, registry-miss errors,
lifecycle-untouched-on-failure, orthogonality with
mode/composition/index/beat, thesceneoverridesindexidentity rule, and end-to-end loading via the resolver bridge).
Test plan
pnpm lint && pnpm typecheck && pnpm test— green (379 tests).pre-commit run --all-files— green.devbase.OKand zero open issues / hotspotson the PR.
Closes #17