Add PUL-F010 regression anchors for composition+index URL parameter#73
Merged
Brad-Edwards merged 1 commit intodevfrom May 4, 2026
Merged
Add PUL-F010 regression anchors for composition+index URL parameter#73Brad-Edwards merged 1 commit intodevfrom
Brad-Edwards merged 1 commit intodevfrom
Conversation
PUL-F010's runtime path (parser, dispatcher, loader) shipped with PUL-F008 (PR #70) and was reinforced for PUL-F009 by PR #72; this PR pins PUL-F010's distinctive contract — the index parameter positions playback at the zero-based composition entry — at the loader boundary so a future refactor cannot silently collapse composition-index to a head-of-manifest load, off-by-one the index, or single-load manifest[index] and drop trailing entries. Also extends ADR-013 and ADR-014 to name PUL-F010 explicitly: ADR-013 records that index is not scene identity / id alias / persistent bookmark and adds the "PUL-F010 forks from composition path" risk + mitigation; ADR-014 records that composition+index is PUL-F010's positional navigation behavior and adds the "index handling creates a second playback state machine" risk + mitigation.
|
Contributor
Author
|
gc_codex_review cycle 1 of 2 complete for PR #73. Posted by the MCP server to enforce the hard-cap-2 contract (issue #794). Do not edit or delete — used by the next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
PUL-F010 — when the
indexURL parameter is present alongside acomposition, the runtime SHALL position playback at the givenzero-based index within the composition.
The runtime path that satisfies PUL-F010 already shipped end-to-end
with PUL-F008 (PR #70) and was reinforced for PUL-F009 by PR #72.
This PR pins PUL-F010's distinctive contract — the
indexparameterpositions playback at the zero-based composition entry — at the
loader boundary, following the regression-anchor precedent set by
the PUL-F009 PR (
tests/runtime/scene-loader.test.ts:177).What changed
tests/runtime/scene-loader.test.ts— new describe block'composition + index positions playback (PUL-F010)'with tworegression anchors:
?composition=trailer&index=2against a 4-entry manifest selectsmanifest[2]as the head and slices forward (proves zero-basedpositional semantics for N > 1; distinguishes from PUL-F009's
index=1anchor).loader.handle()calls against the samecomposition with
index=0thenindex=2resolve to differenthead scenes (proves the
indexparameter — not the compositionid — decides where in the composition playback starts).
docs/adrs/013-url-navigation-grammar-boundary.md— extends ADR-013to name PUL-F010 explicitly:
indexis not scene identity, an idalias, or a persistent bookmark; adds the "PUL-F010 forks from the
existing composition path" risk + mitigation.
docs/adrs/014-url-scene-target-selection.md— records thatcomposition+indexis PUL-F010's positional navigationbehavior, that the head scene is
manifest[index], and adds the"index handling creates a second playback state machine" risk +
mitigation.
CHANGELOG.md— entries for the new anchors and the ADR updates.No production code changes. The runtime contract PUL-F010 names was
already satisfied by the dispatcher (
resolveSceneNavigation→resolveCompositionAndIndexinsrc/runtime/scene-navigation.ts)and the loader (
createSceneLoaderinsrc/runtime/scene-loader.ts).Test plan
pnpm lint— cleanpnpm typecheck— cleanpnpm test— 510 tests pass (12 files; scene-loader specgrew from 19 → 21 tests with the two new anchors)
pre-commit run --all-files— cleangc_codex_review(uncommitted, cycle 1) — 0 findings (corereviewer + security reviewer)
Closes #19