Fix unused variables - #486
Open
sandr01d wants to merge 1 commit into
Open
Conversation
chefranov
added a commit
to chefranov/qmk_firmware
that referenced
this pull request
Aug 13, 2026
The battery percentage was only ever pushed into the wireless module, which exposes it through the bluetooth battery service. A host reached through the 2.4GHz receiver therefore had no way to ask for it at all. Answer command 0xA4 with the cached percentage, as Keychron#504 does. Also drop the checksum computed and then discarded in lkbt51_dfu_tx(), which summed buf[i] instead of buf[k] and so was not a checksum in the first place. Same removal as Keychron#486.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes unused variables. These are usually only warning but become errors due to
-Werrorbeing set incommon_rules.mk.Types of Changes
Checklist