Skip to content

Configurable metrics RBAC, custom Command metadata #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Nov 15, 2023
Merged

Configurable metrics RBAC, custom Command metadata #11

merged 23 commits into from
Nov 15, 2023

Conversation

@m8rmclaren
Copy link
Contributor

@m8rmclaren m8rmclaren commented Oct 4, 2023

No description provided.

@m8rmclaren m8rmclaren self-assigned this Oct 4, 2023
This was linked to issues Oct 4, 2023
[enhancement]capability to pass metadata field to keyfactor #10
Closed
[bug] helm chart crds need to be updated #9
Closed
@m8rmclaren m8rmclaren added bug Something isn't working enhancement New feature or request labels Oct 4, 2023
@m8rmclaren m8rmclaren mentioned this pull request Oct 4, 2023
Closed
@m8rmclaren
Copy link
Contributor Author

m8rmclaren commented Oct 9, 2023

Release pending approval of PR #12

m8rmclaren and others added 11 commits October 9, 2023 10:32
@m8rmclaren
Merge pull request #12 from Keyfactor/metadata
baf4658 
Signer recognizes  annotation prefix for Command metadata and Role/RoleBinding permissions are audited
@m8rmclaren
chore: Create feature parity between cert-manager certificaterequest …
5839f48 
…and command-issuer, update docs
@m8rmclaren
chore: Change action workflow to pull from vars instead of secrets fo…
050247e 
…r nonprotective fields
@m8rmclaren
fix(signer): Copy CN to DNS SAN for signer test
0d0a5e2
@m8rmclaren
Merge pull request #14 from Keyfactor/cmparity
e9cb114 
Return CA as separate field for `certificaterequest` object
@m8rmclaren
chore: Clarify hostname requirements, refactor examples to include ex…
b76c246 
…tended capabilities
@m8rmclaren
chore: Clarify hostname requirements, refactor examples to include ex…
df34fe2 
…tended capabilities
@m8rmclaren
chore: Refactor Helm steps in readme and update makefile to download …
3c13468 
…latest
@m8rmclaren
Merge pull request #15 from Keyfactor/docs
2b23cef 
chore: Clarify hostname requirements, refactor examples to include extended capabilities
@m8rmclaren
chore: Refactor Docs to use doc tree instead of lengthy readme
0a55ed3
@m8rmclaren
Merge pull request #16 from Keyfactor/docs
c9e1a7b 
chore: Refactor Docs to use doc tree instead of lengthy readme
@m8rmclaren
Copy link
Contributor Author

m8rmclaren commented Oct 25, 2023

v1.0.4

Features

  • feat(signer): Signer recognizes metadata.command-issuer.keyfactor.com/<metadata-field-name>: <metadata-value> annotations on the CertificateRequest resource and uses them to populate certificate metadata in Command.
  • feat(release): Container build and release now uses GitHub Actions.

Fixes

  • fix(helm): CRDs now correspond to correct values for the command-issuer.
  • fix(helm): Signer Helm Chart now includes a secureMetrics value to enable/disable sidecar RBAC container for further protection of the /metrics endpoint.
  • fix(signer): Signer now returns CA chain bytes instead of appending to the leaf certificate.
  • fix(role): Removed permissions for configmaps resource types for the leader-election-role role.

@m8rmclaren
Merge pull request #18 from Keyfactor/localdev
037e9d9 
fix(makefile): Bug naming convention in deploy-local target
fiddlermikey
fiddlermikey approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@fiddlermikey fiddlermikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

received signoff approval, thanks Brad

@fiddlermikey fiddlermikey merged commit ff390bb into v1.0.4 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fiddlermikey fiddlermikey fiddlermikey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@m8rmclaren m8rmclaren

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[enhancement]capability to pass metadata field to keyfactor [bug] helm chart crds need to be updated

3 participants

@m8rmclaren @fiddlermikey