Signer recognizes annotation prefix for Command metadata and Role/RoleBinding permissions are audited #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Command Issuer for cert-manager now recognizes K8s annotations with prefix
metadata.command-issuer.keyfactor.com/, and adds<metadata-field-name>: <metadata-value>fields corresponding tometadata.command-issuer.keyfactor.com/<metadata-field-name>: <metadata-value>annotations in POST requests to Command for CSR enrollment.Specifically, the Metadata
mapis updated with matching annotations at the time of signing:Additionally, the rules configured on the
leader-election-rolewere audited and the following rule was removed:https://github.com/Keyfactor/command-cert-manager-issuer/blob/4be4d38bba9395663c38ca85689887596834afe5/deploy/charts/command-cert-manager-issuer/templates/role.yaml#L8C1-L19C15
In early Kubernetes deployments before the
coordination.k8s.iogroup existed,configmapswere commonly used for leader election, whereby obtaining a lock on a specific ConfigMap, a controller instance designates itself as the leader. This is no longer necessary, so theconfigmaprule was removed.