adding pipe feature in cli - #84
Merged
Merged
Conversation
harsh-sikhwal
approved these changes
Sep 1, 2026
ajbalogh
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infragraph translate <tool> | infragraph visualize --output OUT_DIRto work directly:translatewrites its YAML/JSON to stdout instead of a file when--outputis omitted and its stdout is an actual OS pipe, andvisualizereads the infrastructure definition from stdin when--inputis omitted and its stdin is an actual OS pipe.stat.S_ISFIFOon the fd (not justisatty()), so it only kicks in for a real shell|pipe — standalone runs and>-redirected output keep writing/reading files exactly as before.translate's status/log lines (e.g.translated output file ...,Annotated infragraph ... written to ...) from stdout to stderr so they never get mixed into piped or redirected data.Test plan
infragraph translate lstopo --input <xml>still writesdevice.yamlwith the status line printed (existing behavior unchanged).infragraph translate lstopo --input <xml> > out.yamlstill writesdevice.yaml(notout.yaml, which now stays empty since status moved to stderr) — confirms>redirection isn't mistaken for a pipe.infragraph translate lstopo --input <xml> | infragraph visualize --output viz_outproduces a workingviz_out/index.html.infragraph visualize --output viz_outwith no--inputand no piped stdin fails with a clearInvalid value for --inputerror instead of hanging or crashing.infragraph visualize --input device.yaml --output viz_out(explicit file) still works unchanged.