Change KTX_FEATURE_STATIC_LIBRARY to BUILD_SHARED_LIBS#953
Merged
Conversation
|
|
MarkCallow
approved these changes
Oct 28, 2024
richgel999
pushed a commit
to BinomialLLC/KTX-Software-Binomial-Fork
that referenced
this pull request
Mar 9, 2026
) This changes KTX_FEATURE_STATIC_LIBRARY to the built-in cmake variable BUILD_SHARED_LIBS. Static builds are enforced for fmt and astc-encoder. Both libraries use BUILD_SHARED_LIBS themself, so this fixes issues if KTX-Software is used as dependecy in other projects (which set BUILD_SHARED_LIBS). Fixes KhronosGroup#935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes KTX_FEATURE_STATIC_LIBRARY to the inbuild cmake variable BUILD_SHARED_LIBS
Static builds are enforced for fmt and astc-encoder.
Both library use BUILD_SHARED_LIBS themself, so this fixes issues if KTX-Software is used as dependecy in other projects (which set BUILD_SHARED_LIBS)
Fixes #935