Fix minor command-buffer extension typo#780
Merged
bashbaug merged 1 commit intoKhronosGroup:mainfrom Apr 21, 2022
Merged
Conversation
The return type of `clCreateCommandBufferKHR` is missing the `_khr` suffix in its definition.
bashbaug
approved these changes
Apr 21, 2022
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
Nice catch, thank you for fixing this.
Seems like this is another reason we should move to using generated snippets from the XML file in these specifications!
Contributor
|
Not sure people are aware of this but since I landed 1606dc8, it's actually very easy to do and snippets are already generated by default and you could have fixed the prototype by replacing the code with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cl_command_buffer_khrreturn type ofclCreateCommandBufferKHRis missing the_khrsuffix in its definition.