publish ext image extensions#141
Merged
bashbaug merged 1 commit intoKhronosGroup:mainfrom Jun 14, 2023
Merged
Conversation
Contributor
bashbaug
commented
Jun 13, 2023
bashbaug
commented
- cl_ext_image_from_buffer (spec source PR: Add specification for cl_ext_image_from_buffer OpenCL-Docs#752)
- cl_ext_image_requirements_info (spec source PR: Add specification for cl_ext_image_requirements_info OpenCL-Docs#750)
Contributor
Author
|
@kpet heads up, I've converted this PR to a "draft" because there are a few issue I think we'll want to fix in the extension source before publishing:
Thanks! |
kpet
added a commit
to kpet/OpenCL-Docs
that referenced
this pull request
Jun 14, 2023
…age_from_buffer - Fix status of cl_ext_image_requirements_info - Use macros for all commands and enums - Fix mismatched parenthesis See KhronosGroup/OpenCL-Registry#141 Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: I36ae9926e1da3fcf9c74d221888d30ab61c75b4e
Contributor
|
@bashbaug I've created KhronosGroup/OpenCL-Docs#942 to tidy up the sources. I see what you mean regarding the indentation but I've exhausted the time I could afford to spend convincing asciidoctor to not do that. I don't think it's ugly enough to require blocking publication but if you happen to know the magic runes to align those paragraphs, any pointers would be welcome! :) |
bashbaug
pushed a commit
to KhronosGroup/OpenCL-Docs
that referenced
this pull request
Jun 14, 2023
…age_from_buffer (#942) - Fix status of cl_ext_image_requirements_info - Use macros for all commands and enums - Fix mismatched parenthesis See KhronosGroup/OpenCL-Registry#141 Change-Id: I36ae9926e1da3fcf9c74d221888d30ab61c75b4e Signed-off-by: Kevin Petit <kevin.petit@arm.com>
cl_ext_image_from_buffer cl_ext_image_requirements_info
bashbaug
force-pushed
the
publish-ext-image-extensions
branch
from
f052b1b to
4c95309
Compare
Contributor
Author
|
I've rebuilt the specs after merging KhronosGroup/OpenCL-Docs#942. I think this is ready to go now. For the record, I think it's a little weird to publish a shipping spec as v0.5, but if this is intended I don't think it should block publication. Thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.