MSL: Add option to provide a default point size. #2474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidbus
changed the title
squidbus
force-pushed
the
point-size-default
branch
2 times, most recently
from
adc494c to
ada5877
Compare
| return; | ||
|
|
||
| auto &type = this->get<SPIRType>(var.basetype); | ||
| if (need_point_size && has_decoration(type.self, DecorationBlock)) |
Contributor
There was a problem hiding this comment.
Does this handle case where point size is a standalone variable?
Contributor
Author
There was a problem hiding this comment.
Slipped my mind there could be multiple ways to define, I added the built-in check below as well which should handle this.
main.cpp
Outdated
| cbs.add("--msl-auto-disable-rasterization", [&args](CLIParser &) { args.msl_auto_disable_rasterization = true; }); | ||
| cbs.add("--msl-default-point-size", | ||
| [&args](CLIParser &parser) | ||
| { |
Contributor
There was a problem hiding this comment.
Seems like applying the style nit in web viewer didn't work <_< I'll do it locally before merging.
Contributor
Author
There was a problem hiding this comment.
I think I got what you wanted assuming it's like some of the other lines, fixed in commit.
Contributor
There was a problem hiding this comment.
Close enough (don't use static_cast for plain arithmetic types).
squidbus
force-pushed
the
point-size-default
branch
from
bcf3764 to
8b91a44
Compare
HansKristian-Work
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VK_KHR_maintenance5requires thatPointSizedefault to1.0when not written in a shader. In order to support this requirement, this PR adds an option for MSL to emit a defaultPointSizevalue when it was not written, as according to Metal documentation the point size must be specified within the vertex shader.I considered using the existing
enable_point_size_builtinflag for this but it currently defaults to true. Changing this could negatively impact users relying on the default conversion behavior respectingPointSize, and leaving it means every shader emits a default value unless explicitly disabled. Thus I added a new flag to control emitting the default, and a new float option to set what that default is.Have also added tests with this option where the point size is provided by the shader, meaning it should not be defaulted, and where the point size is not provided by the shader, meaning it should be.