Skip to content

Conversation

@squidbus
Copy link
Contributor

@squidbus squidbus commented Apr 29, 2025

Add option for providing OpSMod behavior accurate to the SPIR-V spec, as required by VK_KHR_maintenance8. Made it optional since it generates less clean output than just using the standard operator when this behavior is not needed, and Vulkan does not require it to be accurate without maintenance8 enabled. Probably not the most ideal implementation of this but it’s the best I could figure out how to implement in this context.

CTS results for dEQP-VK.spirv_assembly.*.maintenance8.* using MoltenVK (unsupported tests are geometry shaders):

Test run totals:
  Passed:        24/28 (85.7%)
  Failed:        0/28 (0.0%)
  Not supported: 4/28 (14.3%)
  Warnings:      0/28 (0.0%)
  Waived:        0/28 (0.0%)

@squidbus squidbus force-pushed the accurate-smod branch 2 times, most recently from 40a70c0 to 3b2951b Compare May 2, 2025 10:10
@squidbus squidbus changed the title Add option for accurate negative OpSMod behavior. Use accurate negative OpSMod behavior. May 2, 2025
@HansKristian-Work HansKristian-Work merged commit f1cb5b6 into KhronosGroup:main May 2, 2025
10 checks passed
@squidbus squidbus deleted the accurate-smod branch May 3, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants