-
Notifications
You must be signed in to change notification settings - Fork 628
Use accurate negative OpSMod behavior. #2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da6f81a to
17bd620
Compare
40a70c0 to
3b2951b
Compare
HansKristian-Work
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option for providing
OpSModbehavior accurate to the SPIR-V spec, as required byVK_KHR_maintenance8. Made it optional since it generates less clean output than just using the standard operator when this behavior is not needed, and Vulkan does not require it to be accurate withoutmaintenance8enabled. Probably not the most ideal implementation of this but it’s the best I could figure out how to implement in this context.CTS results for
dEQP-VK.spirv_assembly.*.maintenance8.*using MoltenVK (unsupported tests are geometry shaders):