GLSL/MSL: Add support for SPV_KHR_quad_control. #2479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the execution modes and instructions of
SPV_KHR_quad_controlfor GLSL and MSL.For GLSL, everything translates basically 1:1 to the corresponding
GL_EXT_shader_quad_control. For MSL, we usequad_allandquad_anyfor the instructions, and the execution modes for quad derivatives and full quads pass tests without doing anything special.With the changes in my OpSMod fix PR, this passes all of the CTS tests for
dEQP-VK.subgroups.shader_quad_control.*on MoltenVK.