Fixes for Dawn gn build. #6117
Merged
Fixes for Dawn gn build. #6117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix build.gn for recent updates in table generation - GLSL and OpenCL extended instructions are generated like other vendor extended instruction sets - Core table generation was reworked. We don't need a GN template. - Add more constructors for InstructionDesc and OperandDesc. The compiler didn't like the brace-initialization without a matching constructor with exactly the same parameters.
alan-baker
approved these changes
May 1, 2025
wooyoungqcom
pushed a commit
to CodeLinaro/SPIRV-Tools
that referenced
this pull request
May 5, 2025
- Fix build.gn for recent updates in table generation - GLSL and OpenCL extended instructions are generated like other vendor extended instruction sets - Core table generation was reworked. We don't need a GN template. - Add more constructors for InstructionDesc and OperandDesc. The compiler didn't like the brace-initialization without a matching constructor with exactly the same parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build.gn for recent updates in table generation
GLSL and OpenCL extended instructions are generated like other vendor extended instruction sets
Core table generation was reworked. We don't need a GN template.
Add more constructors for InstructionDesc and OperandDesc. The compiler didn't like the brace-initialization without a matching constructor with exactly the same parameters.