Merged
Conversation
scripts/before_script.sh
Outdated
| if [ "$UPPERCASE_BUILD_TARGET" = "ANDROID" ] | ||
| then | ||
| if [ -n $ANDROID_KEYSTORE_BASE64 ] | ||
| then |
Contributor
There was a problem hiding this comment.
[](start = 0, length = 1)
nit: one tab in the file
AdamMitchell-ms
approved these changes
Jan 9, 2020
github-actions bot
pushed a commit
to Rhinox-Training/UnityGLTF
that referenced
this pull request
Nov 9, 2022
- Updated documentation and actual project to 2018.4.14f1 - Overhauled the Travis build to use a docker image of a matching version of Unity. (Includes running the playmode and editmode tests) - Updated the skybox to individual images, since the .dds appears unsupported in 2018 (it was never officially supported) - Updated lighting and unit tests, bringing them even closer to the provided sample images (though still quite a ways off from being able to image compare against them instead of our own _EXPECTED images). Changes to Main and TestScenePrefab are primarily re-serialization from the Unity upgrade. Practically the changes were adjusting the lighting and fixing the Model List to point at the loader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to Unity 2018 (Issue #503)
Changes to Main and TestScenePrefab are primarily re-serialization from the Unity upgrade. Practically the changes were adjusting the lighting and fixing the Model List to point at the loader.