cmake: Use VulkanHeaders_VERSION#1101
cmake: Use VulkanHeaders_VERSION#1101juan-lunarg merged 1 commit intoKhronosGroup:masterfrom juan-lunarg:juaramos/VulkanHeaders_VERSION
Conversation
Removes need for a bit of python code / parsing. And it's consistent with VVL's approach.
|
CI Vulkan-Loader build queued with queue ID 53797. |
|
CI Vulkan-Loader build # 1691 running. |
|
CI Vulkan-Loader build # 1691 passed. |
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
ACK! I didn't realize this change is subtly breaking behavior. I still want it (parsing the header version manually is yuck), but this PR removes a checked in file. It shouldn't to make CMake generate the file now that the info is 'in' the header's CMake code.
The reason there was a checked in file with the version was so that the generated code had a 'version' associated with it.
Because, while the headers always has an associated version, when building the code the version that is 'used to generate the code' may differ from the header version currently being compiled against. This made it possible to see exactly which header version the autogen code is based on.
3 participants
Removes need for a bit of python code / parsing.
And it's consistent with VVL's approach.