-
Notifications
You must be signed in to change notification settings - Fork 47
V2 UI Improvements #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 UI Improvements #146
Conversation
|
@javagl Here's the PR with the latest for the V2 changes. You'll need to run this locally, and your mileage may vary. Please let me know if you find any issues. |
|
I probably cannot do a sensible "review" here. The actual changes here mainly refer to the UI. I had to do a websearch what "tailwind" actually is, but bailed out when I saw that this is just another framework that wraps the unbearable complexity of CSS away (not necessarily into something that is less complex, but maybe just complex in a different way...). When it comes to style and appearance, I'm more on the ... let's say 'pragmatic' side of things (c.f. https://javagl.github.io/GLConstantsTranslator/GLConstantsTranslator.html ). I have seen that there are some structures prepared for the last checkbox, namely for the "Details View", but am not sure about the current state of this. I started looking at the code, but also might need a refresher for React in general: For some things, I'm not sure whether this is part of a reviewable design- or implementation choice, or whether they are just "that's how we roll" in React. However, more on the ""backend""/structural side:
I initially wanted to post the following block in #122 , because it is rather "brainstorming" - but not in terms of functionality, but rather in terms of "architecture", so it did not really fit there. I hope it's OK to drop this here... I saw that there are a few things that are probably related to #144, namely, a NOTE: This part was unrelated to the pure UI changes here, and has therefore been moved to #151
A few things that could actually be part of a "code review":
(but maybe these are due to the 'draft' state) |
|
@javagl As discussed, I've moved the detail screen and extensions work into a branch and cleaned this one up so we can merge it. Please take a look and let me know if you have any questions. |
|
I had a look at the updated state (i.e. the changes), but as I mentioned above, I'd need to dive deeper into React in order to be able to identify any issues here (beyond the high-level ones, like 'There are no comments'). However, I started the updated state locally, and tried it out, including wild clicking and filtering and changing the window size (c.f. OK for me to merge this. I'll carve out some of the 'brainstorming' above into a dedicated issue. |
|
Thanks, @javagl. I am going to go ahead and merge this into the repo now. |
This in-progress PR contains the major UI improvements for V2.