feat(gastown): configurable terminal orientation with drag-to-resize#1299
Open
feat(gastown): configurable terminal orientation with drag-to-resize#1299
Conversation
…1237) Terminal bar can be positioned at bottom/top/left/right with drag-to-resize. Position and size persisted to localStorage. Collapsed state only reserves the tab bar strip. Dynamic page padding replaces static pb-[340px]. DrawerStack offsets when terminal is on the right.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)N/A Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 149,963 tokens |
…tton Re-clamp persisted size when switching position so horizontal minimum (100px) doesn't persist as a too-small vertical width (min 200px). Show close button on agent tabs in vertical mode via absolute positioning on hover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pb-[340px]with aTerminalBarPaddingclient component that dynamically adjusts padding based on position, size, and collapsed state. Collapsed state only reserves the tab bar strip (38px).rightposition when the terminal is placed on the right side of the viewport.Closes #1237
Verification
pnpm typecheck— passes across all workspace packagespnpm run format:check(oxfmt) — passespnpm run lint(oxlint + eslint fallback) — passes across all packagesVisual Changes
N/A — no screenshots available from CLI. The changes add a position picker (4-option grid popup) and a resize handle to the terminal bar. Vertical orientation renders tabs as icon-only with tooltips.
Reviewer Notes
TerminalBarPaddingclient component was extracted because the layout files are Server Components and can't consume React context directly.DrawerStackRendererWithContextwrapper readsuseTerminalBar()to compute the drawer right offset. This is safe becauseDrawerStackProvideris always rendered insideTerminalBarProviderin both layout files.ResizeObserver+fitAddon.fit()inuseXtermPty.ts. TheMayorTerminalPaneadditionally re-fits onposition/sizechanges.MayorTerminalPaneduplicates xterm setup (identified in Fix terminal stability — WebSocket reconnection, resize debounce, control frame filtering #1195) — deduplication is out of scope for this PR.