-
Notifications
You must be signed in to change notification settings - Fork 32
feat(gastown): add real-time throughput gauges and timeseries charts #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jrf0110
wants to merge
1
commit into
main
Choose a base branch
from
1297-realtime-gauges
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
cloudflare-gastown/src/db/tables/metrics-snapshots.table.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| import { z } from 'zod'; | ||
| import { getTableFromZodSchema, getCreateTableQueryFromTable } from '../../util/table'; | ||
|
|
||
| /** | ||
| * Periodic metrics snapshots collected by the alarm handler. | ||
| * One row per alarm tick (~5s when active, ~60s when idle). | ||
| * Used for timeseries charts on the observability tab. | ||
| */ | ||
| export const MetricsSnapshotRecord = z.object({ | ||
| snapshot_id: z.string(), | ||
| /** ISO timestamp of when the snapshot was taken */ | ||
| captured_at: z.string(), | ||
| /** Number of agents in 'working' status */ | ||
| agents_working: z.coerce.number(), | ||
| /** Number of agents in 'idle' status */ | ||
| agents_idle: z.coerce.number(), | ||
| /** Total registered agents */ | ||
| agents_total: z.coerce.number(), | ||
| /** Beads currently open */ | ||
| beads_open: z.coerce.number(), | ||
| /** Beads currently in_progress */ | ||
| beads_in_progress: z.coerce.number(), | ||
| /** Beads currently in_review */ | ||
| beads_in_review: z.coerce.number(), | ||
| /** Bead events recorded since last snapshot */ | ||
| events_since_last: z.coerce.number(), | ||
| /** Beads created since last snapshot */ | ||
| beads_created_since_last: z.coerce.number(), | ||
| /** Beads closed since last snapshot */ | ||
| beads_closed_since_last: z.coerce.number(), | ||
| /** Accumulated input tokens since last snapshot */ | ||
| input_tokens_since_last: z.coerce.number(), | ||
| /** Accumulated output tokens since last snapshot */ | ||
| output_tokens_since_last: z.coerce.number(), | ||
| /** Accumulated cost in microdollars since last snapshot */ | ||
| cost_microdollars_since_last: z.coerce.number(), | ||
| /** Total LOC additions across all agents (absolute snapshot, not delta) */ | ||
| loc_additions: z.coerce.number(), | ||
| /** Total LOC deletions across all agents (absolute snapshot, not delta) */ | ||
| loc_deletions: z.coerce.number(), | ||
| }); | ||
|
|
||
| export type MetricsSnapshotRecord = z.output<typeof MetricsSnapshotRecord>; | ||
|
|
||
| export const metrics_snapshots = getTableFromZodSchema('metrics_snapshots', MetricsSnapshotRecord); | ||
|
|
||
| export function createTableMetricsSnapshots(): string { | ||
| return getCreateTableQueryFromTable(metrics_snapshots, { | ||
| snapshot_id: 'text primary key', | ||
| captured_at: 'text not null', | ||
| agents_working: 'integer not null default 0', | ||
| agents_idle: 'integer not null default 0', | ||
| agents_total: 'integer not null default 0', | ||
| beads_open: 'integer not null default 0', | ||
| beads_in_progress: 'integer not null default 0', | ||
| beads_in_review: 'integer not null default 0', | ||
| events_since_last: 'integer not null default 0', | ||
| beads_created_since_last: 'integer not null default 0', | ||
| beads_closed_since_last: 'integer not null default 0', | ||
| input_tokens_since_last: 'integer not null default 0', | ||
| output_tokens_since_last: 'integer not null default 0', | ||
| cost_microdollars_since_last: 'integer not null default 0', | ||
| loc_additions: 'integer not null default 0', | ||
| loc_deletions: 'integer not null default 0', | ||
| }); | ||
| } | ||
|
|
||
| export function getIndexesMetricsSnapshots(): string[] { | ||
| return [ | ||
| `CREATE INDEX IF NOT EXISTS idx_metrics_snapshots_captured ON ${metrics_snapshots}(${metrics_snapshots.columns.captured_at})`, | ||
| ]; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: The poller never clears LOC back to zero
This POST is skipped whenever
totalAdditionsandtotalDeletionsboth become0. BecausesetLoc()keeps the last reported snapshot until another/loccall arrives, the town can keep showing stale non-zero line counts after a branch is rebased/merged cleanly or after all agents go idle. The poller needs to report the0/0state as well so the gauges can reset.