Skip to content

feat(sessions): switch web session list from unified to cli sessions v2 endpoint#2905

Merged
eshurakov merged 3 commits into
mainfrom
feat/session-list-v2-migration-rebased
Apr 29, 2026
Merged

feat(sessions): switch web session list from unified to cli sessions v2 endpoint#2905
eshurakov merged 3 commits into
mainfrom
feat/session-list-v2-migration-rebased

Conversation

@kilo-code-bot
Copy link
Copy Markdown
Contributor

@kilo-code-bot kilo-code-bot Bot commented Apr 29, 2026

Summary

switch web session list from unified to cli sessions v2 endpoint

Comment thread apps/web/src/components/cloud-agent/CloudSessionsPage.tsx Outdated
@kilo-code-bot
Copy link
Copy Markdown
Contributor Author

kilo-code-bot Bot commented Apr 29, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (10 files)
  • apps/web/src/app/(app)/cloud/sessions/SessionsPageContent.tsx
  • apps/web/src/components/cloud-agent-next/CloudChatPage.tsx
  • apps/web/src/components/cloud-agent-next/CloudSidebarLayout.tsx
  • apps/web/src/components/cloud-agent-next/NewSessionPanel.tsx
  • apps/web/src/components/cloud-agent-next/hooks/useSidebarSessions.ts
  • apps/web/src/components/cloud-agent-next/store/db-session-atoms.test.ts
  • apps/web/src/components/cloud-agent-next/store/db-session-atoms.ts
  • apps/web/src/components/cloud-agent/CloudSessionsPage.tsx
  • apps/web/src/routers/cli-sessions-v2-router.ts
  • apps/web/src/routers/unified-sessions-router.ts

Reviewed by gpt-5.5-2026-04-23 · 1,494,697 tokens

Comment thread apps/web/src/routers/root-router.ts
kilo-code-bot Bot added 3 commits April 29, 2026 14:59
provide a migration plan for the session-list v2 endpoint

outlining steps, milestones, and rollback considerations
- Revert deletion of unified-sessions-router: keep it registered so
  already-loaded client bundles and any external callers on the old
  tRPC path don't break at deploy time. It's intended to be removed in
  a follow-up after a soak window.
- CloudSessionsPage (legacy v1 start flow): invalidate unifiedSessions.list
  instead of cliSessionsV2.list, since cloudAgent.prepareSession writes
  to cli_sessions v1 rows that the v2-only list cache can't contain.
- Replace ILIKE-with-escape-regex search with position()-based substring
  matching in both the v2 and unified routers. Avoids LIKE wildcard
  semantics entirely, so %, _, and \\ in user input are matched literally
  without escaping and the CodeQL incomplete-escape finding no longer
  applies. Drops the migration plan doc now that the migration is
  in-flight.
@kilo-code-bot kilo-code-bot Bot force-pushed the feat/session-list-v2-migration-rebased branch from c1cc8ca to a26b28e Compare April 29, 2026 15:01
@eshurakov eshurakov self-assigned this Apr 29, 2026
@eshurakov eshurakov changed the title feat(sessions): switch web session list from unified to cli sessions v2 endpoint (rebased) feat(sessions): switch web session list from unified to cli sessions v2 endpoint Apr 29, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will get deleted in the follow up PR

@eshurakov eshurakov merged commit 133a6fb into main Apr 29, 2026
16 checks passed
@eshurakov eshurakov deleted the feat/session-list-v2-migration-rebased branch April 29, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants