feat(sessions): switch web session list from unified to cli sessions v2 endpoint#2905
Merged
Merged
Conversation
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (10 files)
Reviewed by gpt-5.5-2026-04-23 · 1,494,697 tokens |
provide a migration plan for the session-list v2 endpoint outlining steps, milestones, and rollback considerations
- Revert deletion of unified-sessions-router: keep it registered so already-loaded client bundles and any external callers on the old tRPC path don't break at deploy time. It's intended to be removed in a follow-up after a soak window. - CloudSessionsPage (legacy v1 start flow): invalidate unifiedSessions.list instead of cliSessionsV2.list, since cloudAgent.prepareSession writes to cli_sessions v1 rows that the v2-only list cache can't contain. - Replace ILIKE-with-escape-regex search with position()-based substring matching in both the v2 and unified routers. Avoids LIKE wildcard semantics entirely, so %, _, and \\ in user input are matched literally without escaping and the CodeQL incomplete-escape finding no longer applies. Drops the migration plan doc now that the migration is in-flight.
c1cc8ca to
a26b28e
Compare
eshurakov
reviewed
Apr 29, 2026
Contributor
There was a problem hiding this comment.
this will get deleted in the follow up PR
jrf0110
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
switch web session list from unified to cli sessions v2 endpoint