Skip to content

feat(wasteland): debounce wanted board search input#3349

Open
jrf0110 wants to merge 1 commit into
mainfrom
sync/wanted-board-search-debounce
Open

feat(wasteland): debounce wanted board search input#3349
jrf0110 wants to merge 1 commit into
mainfrom
sync/wanted-board-search-debounce

Conversation

@jrf0110
Copy link
Copy Markdown
Contributor

@jrf0110 jrf0110 commented May 19, 2026

Summary

  • Syncs the fork PR that debounces wanted board search input updates before writing q to the URL.
  • Keeps local search input responsive while avoiding high-frequency router updates during typing.
  • Clears the URL search parameter immediately when the input is emptied.

Verification

  • Manually verified in fork PR: search inputs and clear state behavior under latency.

Visual Changes

N/A

Reviewer Notes

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 19, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Debounce implementation is correct and clean — the useRef timeout is properly cleaned up on unmount, preventing memory leaks, and the sync-from-URL useEffect correctly handles external navigation changes.

Files Reviewed (1 file)
  • apps/web/src/app/(app)/wasteland/by-id/[wastelandId]/wanted/WantedBoardClient.tsx

Note: One minor UX observation (not a bug): updateFilterParams trims the search value before writing to the URL (line 182), but localSearch stores the raw input. If a user types trailing spaces, after the debounced URL update fires and the useEffect syncs back search → localSearch, those trailing spaces are stripped mid-typing. This is a very edge case and unlikely to affect real users, but worth being aware of.

Fix these issues in Kilo Cloud


Reviewed by claude-4.6-sonnet-20260217 · 297,516 tokens

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant