Skip to content

feat(cloud-agent): add Gastown badge#3423

Closed
jrf0110 wants to merge 7 commits into
mainfrom
convoy/tag-gastown-sessions-correctly-in-cloud-/2ad5ef09/gt/toast/a3af4c0d
Closed

feat(cloud-agent): add Gastown badge#3423
jrf0110 wants to merge 7 commits into
mainfrom
convoy/tag-gastown-sessions-correctly-in-cloud-/2ad5ef09/gt/toast/a3af4c0d

Conversation

@jrf0110
Copy link
Copy Markdown
Contributor

@jrf0110 jrf0110 commented May 22, 2026

Adds a Gastown badge to SessionsList components for sessions with createdOnPlatform 'gastown'.

jrf0110 and others added 7 commits May 19, 2026 20:32
…rm (#3372)

Bug 1: @kilocode/cli@7.2.14 doesn't read KILO_AUTH_CONTENT, causing all
kilo serve session-ingest to silently no-op. Bumped to 7.3.1 which has the
feature. Verified KILO_AUTH_CONTENT present in binary strings.

Bug 2: buildPrewarmEnv didn't set KILO_AUTH_CONTENT, KILO_PLATFORM, or
KILO_ORG_ID, so mayor sessions (which go through prewarm) were invisible.
Extracted buildKiloAuthEnv helper from buildAgentEnv and used it in both
buildAgentEnv and buildPrewarmEnv.

Refs #3307

Co-authored-by: John Fawcett <john@kilcoode.ai>
* perf(gastown): shorten mayor cold start path

* fix(gastown): address mayor latency review feedback

* fix(gastown): remove stale mayor setup parameter

* fix(gastown): remove stale mayor setup comment
</span>
);
}
} else if (platform === 'slack') {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Indentation is broken — } else if (platform === 'slack') { is at column 0 instead of matching the surrounding else if branches (8 spaces). This same pattern repeats in apps/web/src/components/cloud-agent/SessionsList.tsx line 74. The code is syntactically correct (React renders fine) but is visually inconsistent and will be a diff noise issue in future PRs.

</span>
);
}
} else if (platform === 'slack') {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Same indentation issue as in cloud-agent-next/SessionsList.tsx} else if (platform === 'slack') { starts at column 0 instead of being indented to match the surrounding else if blocks.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 22, 2026

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Executive Summary

Broken indentation on both SessionsList.tsx files leaves } else if (platform === 'slack') { at column 0, inconsistent with all surrounding branches.

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/web/src/components/cloud-agent-next/SessionsList.tsx 72 } else if (platform === 'slack') { is at column 0 — should be indented to match surrounding else if branches (8 spaces)
apps/web/src/components/cloud-agent/SessionsList.tsx 74 Same broken indentation on the slack branch
Other Observations (not in diff)

Bootstrapping gap during cold start (container-dispatch.ts): In startAgentInContainer, the PR switches from ensureContainerToken (which called /refresh-token to push the token to already-running agents) to mintContainerToken (which only mints, no push). This is intentional — the comment explains new dispatches get the token in their start request. However, the token is now not pushed to already-running SDK children on cold-start dispatch. The alarm path (ensureContainerToken) still handles rotation for long-lived containers, so the risk is low, but on a fresh boot with multiple agents resuming (registry hydration path), non-mayor agents use the GASTOWN_CONTAINER_TOKEN overlaid from the raw token string at hydration time, which is the same fresh value — this looks correct.

Stale container:envVars in DO storage (TownContainer.do.ts): The PR removes setEnvVar/deleteEnvVar and the constructor that loaded container:envVars from DO storage. Existing live TownContainerDO instances that have previously stored KILOCODE_TOKEN and other keys in container:envVars will silently have that data orphaned in storage (never read, never cleaned). This is benign — the data won't be used — but it may be worth a one-time migration to delete the key if storage hygiene matters.

warmUp now requires a townId parameter: All call sites pass it correctly. No issue, just noting the signature change is a breaking RPC change for the DO — Cloudflare will not allow in-flight calls to the old zero-arg signature during deployment. This is safe because warmUp is only called from TownDO (same Worker), not from external callers.

Files Reviewed (18 files)
  • apps/web/src/components/cloud-agent-next/SessionsList.tsx — 1 issue
  • apps/web/src/components/cloud-agent/SessionsList.tsx — 1 issue
  • services/gastown/container/src/agent-runner.ts
  • services/gastown/container/src/agent-runner.test.ts
  • services/gastown/container/src/control-server.ts
  • services/gastown/container/src/main.ts
  • services/gastown/container/src/process-manager.ts
  • services/gastown/container/src/process-manager.test.ts
  • services/gastown/src/dos/Town.do.ts
  • services/gastown/src/dos/TownContainer.do.ts
  • services/gastown/src/dos/town/config.ts
  • services/gastown/src/dos/town/container-dispatch.ts
  • services/gastown/src/trpc/router.ts
  • services/gastown/container/Dockerfile
  • services/gastown/container/Dockerfile.dev
  • services/gastown/container/package.json
  • services/gastown/wrangler.jsonc
  • pnpm-lock.yaml

Fix these issues in Kilo Cloud


Reviewed by claude-4.6-sonnet-20260217 · 2,739,640 tokens

Review guidance: REVIEW.md from base branch main

@jrf0110
Copy link
Copy Markdown
Contributor Author

jrf0110 commented May 22, 2026

Superseded by #3424, which targets the correct convoy head branch instead of main. Closing as a stray.

@jrf0110 jrf0110 closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant