CloudAgentNext - Per-provider credential containment allow-lists#4504
Merged
Conversation
Replace the single MANAGED_SCM_CONTAINMENT_ORG_IDS env var and managedScmContainment
boolean with per-provider containment allow-lists (GITHUB_TOKEN_CONTAINMENT_ORG_IDS,
GITLAB_TOKEN_CONTAINMENT_ORG_IDS, KILOCODE_TOKEN_CONTAINMENT_ORG_IDS) and a
credentialContainment { github, gitlab, kilocode } workspace metadata field.
Add getEffectiveCredentialContainment and requiresContainmentSandbox helpers that
migrate legacy managedScmContainment metadata. Token resolution and sandbox routing
now respect per-provider containment independently.
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Fix these issues in Kilo Cloud Files Reviewed (15 files)
Reviewed by gpt-5.6-sol-20260709 · Input: 313.2K · Output: 21.6K · Cached: 6.5M Review guidance: REVIEW.md from base branch |
jeanduplessis
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the single
MANAGED_SCM_CONTAINMENT_ORG_IDSenv var andmanagedScmContainmentboolean with per-provider containment allow-lists, so GitHub, GitLab, and Kilo tokens can be contained independently.Changes
MANAGED_SCM_CONTAINMENT_ORG_IDS→GITHUB_TOKEN_CONTAINMENT_ORG_IDS,GITLAB_TOKEN_CONTAINMENT_ORG_IDS,KILOCODE_TOKEN_CONTAINMENT_ORG_IDS(each a comma-separated org allow-list or*).workspace.managedScmContainmentboolean →workspace.credentialContainment{ github, gitlab, kilocode }, with a Zod schema.getEffectiveCredentialContainment(prefers explicit policy, falls back to legacymanagedScmContainment→ github+kilocode) andrequiresContainmentSandbox(true if any provider is contained).resolveKiloCapability.credentialContainmentpolicy from the three org allow-lists (devcontainer sessions stay uncontained).managedScmContainmentmetadata is mapped to the new shape viagetEffectiveCredentialContainment.Test plan
session-metadata.test.tswith legacy migration, explicit-policy precedence, and default-uncontained cases.session-prepare.test.tsandsession-service.test.tsto assert per-provider containment outcomes for GitHub-only, GitLab-only, Kilo-only, and mixed policies.credentialContainmentshape.