feat(mobile): show model picker costs - #4939
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummarySince the last review at Verification notes
Files Reviewed (0 changed PR files in this increment)
Previous Review Summaries (2 snapshots, latest commit 2966a00)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 2966a00)Status: No Issues Found | Recommendation: Merge Executive SummaryThe incremental change since Verification notes
Files Reviewed (1 file)
Previous review (commit 36028c8)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe pricing formatting and suppression logic is sound; the only issue is a newly exported type with no cross-file consumer that knip will flag in CI. Overview
Issue Details (click to expand)WARNING
Verification notes
Files Reviewed (7 files)
Reviewed by claude-opus-5 · Input: 26 · Output: 4.2K · Cached: 477.9K Review guidance: REVIEW.md from base branch |
|
(bot) E2E is blocked before verifier dispatch: two iOS bundle attempts reached |
|
(bot) Follow-up: fresh iOS E2E completed on 2966a00. Paid rows rendered the per-1M cost and included it in VoiceOver labels; Auto Free omitted it. VERIFICATION PASSED. Screenshot and full evidence are in the PR description. |
Summary
What
Why
How
Verification
cd apps/mobile && pnpm format && pnpm typecheck && pnpm lint && pnpm check:unused && pnpm testgit diff --checkIOS-01verified paid rows renderIn $… · Out $… per 1M tokensand include that text in the row accessibility label.IOS-02verifiedAuto Freehas no cost text or accessibility-label segment.VERIFICATION PASSED.on2966a006627fd52b34c160fe64417dc47631f7ab.Visual Changes
After-only: the base branch did not have this cost line to capture in the same verified run.
Non-goals
($$$$)name suffix remain unchanged.