Skip to content

feat(cloud-agent): pin GitHub installation identity - #5485

Merged
RSO merged 2 commits into
mainfrom
multi-github/04-installation-contracts
Aug 26, 2026
Merged

feat(cloud-agent): pin GitHub installation identity#5485
RSO merged 2 commits into
mainfrom
multi-github/04-installation-contracts

Conversation

@RSO

@RSO RSO commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add expectedIntegrationId as an authorization fence in the Git token service
  • include installation identity in capabilities without breaking existing claims
  • persist and validate githubIntegrationId through Cloud Agent session preparation, registration, resume, and credential refresh
  • keep the new contract optional so this can deploy before clients expose secondary repositories

Stack

Validation

  • Git token service: 531 tests passed, typecheck and lint passed
  • Cloud Agent Next: 2,723 tests passed with 3 skipped, typecheck and lint passed

Comment thread services/git-token-service/src/installation-lookup-service.ts
@kilo-code-bot

kilo-code-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (27 files)
  • services/cloud-agent-next/src/persistence/CloudAgentSession.ts
  • services/cloud-agent-next/src/persistence/session-metadata.test.ts
  • services/cloud-agent-next/src/persistence/session-metadata.ts
  • services/cloud-agent-next/src/router/handlers/session-prepare.test.ts
  • services/cloud-agent-next/src/router/handlers/session-prepare.ts
  • services/cloud-agent-next/src/router/handlers/session-start.ts
  • services/cloud-agent-next/src/router/schemas.test.ts
  • services/cloud-agent-next/src/router/schemas.ts
  • services/cloud-agent-next/src/services/git-token-service-client.test.ts
  • services/cloud-agent-next/src/services/git-token-service-client.ts
  • services/cloud-agent-next/src/session-prepare.test.ts
  • services/cloud-agent-next/src/session-service.test.ts
  • services/cloud-agent-next/src/session-service.ts
  • services/cloud-agent-next/src/session/session-prepare.test.ts
  • services/cloud-agent-next/src/session/session-registration.ts
  • services/cloud-agent-next/src/session/session-requests.ts
  • services/cloud-agent-next/src/session/validate-repository-access.test.ts
  • services/cloud-agent-next/src/session/validate-repository-access.ts
  • services/cloud-agent-next/src/types.ts
  • services/git-token-service/src/github-session-capability.test.ts
  • services/git-token-service/src/github-session-capability.ts
  • services/git-token-service/src/github-user-authorization-entrypoint.test.ts
  • services/git-token-service/src/index.test.ts
  • services/git-token-service/src/index.ts
  • services/git-token-service/src/installation-lookup-service.behavior.test.ts
  • services/git-token-service/src/installation-lookup-service.test.ts
  • services/git-token-service/src/installation-lookup-service.ts
Previous Review Summaries (2 snapshots, latest commit 6c43516)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 6c43516)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (27 files)
  • services/cloud-agent-next/src/persistence/CloudAgentSession.ts
  • services/cloud-agent-next/src/persistence/session-metadata.test.ts
  • services/cloud-agent-next/src/persistence/session-metadata.ts
  • services/cloud-agent-next/src/router/handlers/session-prepare.test.ts
  • services/cloud-agent-next/src/router/handlers/session-prepare.ts
  • services/cloud-agent-next/src/router/handlers/session-start.ts
  • services/cloud-agent-next/src/router/schemas.test.ts
  • services/cloud-agent-next/src/router/schemas.ts
  • services/cloud-agent-next/src/services/git-token-service-client.test.ts
  • services/cloud-agent-next/src/services/git-token-service-client.ts
  • services/cloud-agent-next/src/session-prepare.test.ts
  • services/cloud-agent-next/src/session-service.test.ts
  • services/cloud-agent-next/src/session-service.ts
  • services/cloud-agent-next/src/session/session-prepare.test.ts
  • services/cloud-agent-next/src/session/session-registration.ts
  • services/cloud-agent-next/src/session/session-requests.ts
  • services/cloud-agent-next/src/session/validate-repository-access.test.ts
  • services/cloud-agent-next/src/session/validate-repository-access.ts
  • services/cloud-agent-next/src/types.ts
  • services/git-token-service/src/github-session-capability.test.ts
  • services/git-token-service/src/github-session-capability.ts
  • services/git-token-service/src/github-user-authorization-entrypoint.test.ts
  • services/git-token-service/src/index.test.ts
  • services/git-token-service/src/index.ts
  • services/git-token-service/src/installation-lookup-service.behavior.test.ts
  • services/git-token-service/src/installation-lookup-service.test.ts
  • services/git-token-service/src/installation-lookup-service.ts

Previous review (commit a1a5ebe)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
services/git-token-service/src/installation-lookup-service.ts 256 Fenced lookups classify a stale GitHub account login as integration_mismatch, so org-rename repair never runs
Files Reviewed (26 files)
  • services/cloud-agent-next/src/persistence/CloudAgentSession.ts - 0 issues
  • services/cloud-agent-next/src/persistence/session-metadata.test.ts - 0 issues
  • services/cloud-agent-next/src/persistence/session-metadata.ts - 0 issues
  • services/cloud-agent-next/src/router/handlers/session-prepare.test.ts - 0 issues
  • services/cloud-agent-next/src/router/handlers/session-prepare.ts - 0 issues
  • services/cloud-agent-next/src/router/handlers/session-start.ts - 0 issues
  • services/cloud-agent-next/src/router/schemas.test.ts - 0 issues
  • services/cloud-agent-next/src/router/schemas.ts - 0 issues
  • services/cloud-agent-next/src/services/git-token-service-client.test.ts - 0 issues
  • services/cloud-agent-next/src/services/git-token-service-client.ts - 0 issues
  • services/cloud-agent-next/src/session-prepare.test.ts - 0 issues
  • services/cloud-agent-next/src/session-service.test.ts - 0 issues
  • services/cloud-agent-next/src/session-service.ts - 0 issues
  • services/cloud-agent-next/src/session/session-prepare.test.ts - 0 issues
  • services/cloud-agent-next/src/session/session-registration.ts - 0 issues
  • services/cloud-agent-next/src/session/session-requests.ts - 0 issues
  • services/cloud-agent-next/src/session/validate-repository-access.test.ts - 0 issues
  • services/cloud-agent-next/src/session/validate-repository-access.ts - 0 issues
  • services/cloud-agent-next/src/types.ts - 0 issues
  • services/git-token-service/src/github-session-capability.test.ts - 0 issues
  • services/git-token-service/src/github-session-capability.ts - 0 issues
  • services/git-token-service/src/index.test.ts - 0 issues
  • services/git-token-service/src/index.ts - 0 issues
  • services/git-token-service/src/installation-lookup-service.behavior.test.ts - 0 issues
  • services/git-token-service/src/installation-lookup-service.test.ts - 0 issues
  • services/git-token-service/src/installation-lookup-service.ts - 1 issue

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 242.6K · Output: 14.6K · Cached: 514.4K

Review guidance: REVIEW.md from base branch main

@RSO
RSO force-pushed the multi-github/03-reviewer-pilot branch from 04081b8 to 74a0762 Compare August 26, 2026 09:42
@RSO
RSO force-pushed the multi-github/04-installation-contracts branch from a1a5ebe to b3ce826 Compare August 26, 2026 11:23
@RSO
RSO changed the base branch from multi-github/03-reviewer-pilot to main August 26, 2026 11:23
@RSO
RSO marked this pull request as ready for review August 26, 2026 11:33
@RSO
RSO force-pushed the multi-github/04-installation-contracts branch from 6c43516 to 05fe57e Compare August 26, 2026 11:54
@RSO
RSO merged commit a6dfd98 into main Aug 26, 2026
13 checks passed
@RSO
RSO deleted the multi-github/04-installation-contracts branch August 26, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants