feat(cloud-agent-next): add interactive control-plane terminals - #5508
Merged
Conversation
eshurakov
force-pushed
the
eshurakov/silver-atlas
branch
from
August 26, 2026 09:45
dee12fe to
7aa468b
Compare
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the retryable close fix confirms wrapper deletion is required before Files Reviewed (4 files)
Previous Review Summaries (2 snapshots, latest commit 89b34be)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 89b34be)Status: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Previous review (commit 7aa468b)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (48 files)
Reviewed by grok-4.6 · Input: 66.1K · Output: 11.5K · Cached: 548.6K Review guidance: REVIEW.md from base branch |
Relay workspace_* PTYs through SandboxSession over reverse WebSockets while keeping terminal bytes off the JSON control socket. Bind runtime identity, scrub credentials, and fail Vercel billing closed.
eshurakov
force-pushed
the
eshurakov/silver-atlas
branch
from
August 26, 2026 13:02
7aa468b to
89b34be
Compare
pandemicsyn
approved these changes
Aug 26, 2026
pandemicsyn
left a comment
pandemicsyn
left a comment
Contributor
There was a problem hiding this comment.
lgtm, one from the bot inline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add interactive terminals for
workspace_*sessions on the existing call-home control plane. Shared control messages negotiate terminal lifecycle; authenticated single-use reverse WebSockets relay raw PTY frames throughSandboxSession. Legacyagent_*terminals are unchanged.PTYs are bound to owner, session, root Kilo session, workspace directory, sandbox, wrapper runtime, and bridge generation. Credentials are scrubbed from the attach environment. Vercel billing stays fail-closed.