feat(webhooks): let each trigger choose its GitHub organization - #5567
Closed
RSO wants to merge 1 commit into
Closed
feat(webhooks): let each trigger choose its GitHub organization#5567RSO wants to merge 1 commit into
RSO wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Reviewed by grok-4.6 · Input: 284.6K · Output: 20.1K · Cached: 449.7K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR exists
#5564 gives webhook triggers a place to persist GitHub installation identity, but users still need a safe way to choose it. The current form identifies repositories by name, so duplicate repositories from different installations are indistinguishable and editing a trigger can silently switch to another installation.
This PR exposes the backend capability only after preserving repository + account + integration as one selection.
Place in the rollout
This is the UI child of #5564. The split is intentional: #5564 makes storage and execution backward-compatible; this PR is the point where new triggers can actually target secondary GitHub organizations.
Dependency
Depends on #5564. Merge and deploy the backend contract first, then retarget this PR to
main.What changes
platformIntegrationIdin create and edit form state.What stays unchanged
Why this adds a selector component
The existing generic repository field cannot represent duplicate names or unavailable pinned values. The new component keeps that identity handling local to webhook forms rather than broadening a shared selector used by unrelated products.
Review guide
Review
github-repository-selection.tsfirst; it contains the pure grouping and stale-pin rules. Then verifyTriggerFormsends the selected ID on both create and edit.Validation
git diff --checkBrowser testing was skipped because no local services were running.