fix(mobile): defer async initial link updates until mount - #5613
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the CI scoping follow-up that detects affected workspaces from lockfile and patch graphs; no correctness or fail-open gating issues found. Files Reviewed (7 files)
Previous Review Summary (commit 71698a9)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 71698a9)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed the expo-router 57.0.10 patch that defers async initial-link reporting to a cancellable mount effect, plus its mounted regression tests; no correctness, lifecycle, or leak issues found. Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 119.4K · Output: 21.4K · Cached: 385.4K Review guidance: REVIEW.md from base branch |
|
Android verification passed: three cold process launches and one full emulator reboot. Each case reached Home, and runtime logs contained no matching React mount warning. The emulator, Appium server, local stack, and E2E slot are released. The worktree is clean. Mobile CI, repository lint, typecheck, tests, and build passed. The remaining failure is the Chrome extension scroll assertion at |
Summary
Verification
An earlier repeat stopped at the development-client chooser after the host network changed. After regenerating endpoints, all four checks passed.
Local screenshots and logs:
/var/folders/pz/_kmbp8vs2755j415slh2hz100000gn/T/kilo/pr-5613-android/stable-network/.Visual Changes
N/A
Reviewer Notes
CI scoping follow-up
node scripts/changed-dependencies.mjs e186f2d0d 71698a97c; it selects onlyapps/mobile.This PR still exercises extension CI because it changes the extension workflow and root tooling. Repository-wide checks and the web CI gate remain broader. Device verification results are below.
iOS and link verification
Remaining device coverage: Android cold custom-scheme navigation stopped in Expo DevLauncherActivity before the app loaded. One documented recovery failed. Cold profile navigation remains unverified; cold preferences navigation did not run. Native OS delivery of universal links was not tested.
Local evidence:
/var/folders/pz/_kmbp8vs2755j415slh2hz100000gn/T/kilo/pr-5613-links-ios//var/folders/pz/_kmbp8vs2755j415slh2hz100000gn/T/kilo/pr-5613-links-android/All current PR checks passed after the CI-scoping commit, including Chrome extension tests.