feat(agent-harness): read scoped Cloud Agent context and progress - #5726
Open
iscekic wants to merge 1 commit into
Open
feat(agent-harness): read scoped Cloud Agent context and progress#5726iscekic wants to merge 1 commit into
iscekic wants to merge 1 commit into
Conversation
This was referenced Aug 29, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the new scoped Cloud Agent search, attach, and progress reads, including ownership checks and bounded history, with high confidence and no correctness or security issues in the changed code. Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 269K · Output: 25.5K · Cached: 2.4M Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new behavior — this change prepares session features without making them available in the product.
Summary
createHarnessCloudAgentContextadds freshly authorizedkilo.sessions.search,kilo.sessions.attach, andkilo.sessions.progressreads, scoped helpers, and stablemessageIdvalues without adding mutation dispatch.InvocationandToolRequestSchemavalidate requests; search and history return at most 20 items, while attached text remains untrusted and progress exposes status.History uses bounded transport before decoding; requests and validated
ToolOutcome.outputvalues have 64 KiB limits, and existing callers remain unchanged.Files
apps/web/src/lib/agent-harness/cloud-agent-context.ts— added (+164 lines); normalizes invocation identifiers and binds authority and replay identity to the conversation, operation, definition version, arguments, and dispatch. It verifies ownership and returned identities across personal and organization scopes, requires cloud links for progress, and preserves empty history and typed failures. Search returns titles with session identifier fallbacks; attachments retain text only; progress returns execution status, prepared, or idle.The Cloud Agent read tests cover personal and organization scopes, authority revocation between reads, identity checks, byte limits, and stable replay identifiers.
The shared fixture uses authorization and router doubles; two overflow regressions use the real transport to reject oversized non-text history before decoding.
The suite checks failures separately from empty results, but it does not prove live authority or service behavior.
Files
apps/web/src/lib/agent-harness/cloud-agent-context.test.ts— added (+190 lines); covers the three reads, real session linkage, grant rechecks, transport overflow, error mapping, sanitized outputs, and replay identity.apps/web/src/lib/agent-harness/cloud-agent-test-fixture.ts— added (+125 lines); provides resettable personal and organization callers, authority guards, private session data, and controls for revocation, outages, and empty results.Tests: 2 files added (+315 lines):
cloud-agent-context.test.tsandcloud-agent-test-fixture.ts; all 36 focused tests passed.Generated: 0 files changed.
Visual Changes
Visual Changes: N/A
Verification
No manual tests ran because this level does not activate the harness.
Reviewer Notes
Human steps: None before merge or after merge.
Captured format, lint, and patch checks passed. Continuous integration (CI) owns database execution and project-wide type checks.
Runtime verification remains pending at the stack tip. This level adds scoped Cloud Agent reads without activating the harness.
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
shared-agent-harness-3bb0— chore(agent-harness): register workspaces and enforce CI boundaries #5632shared-agent-harness-3bb0-s2— feat(agent-harness): define portable domain and snapshots #5637shared-agent-harness-3bb0-s3— feat(agent-harness): define commands tools and permission policy #5639shared-agent-harness-3bb0-s4— feat(agent-harness): share client state and cursor recovery #5643shared-agent-harness-3bb0-s5— feat(agent-harness): persist command intents and execution receipts #5647shared-agent-harness-3bb0-s6— feat(db): add harness ingress grants and retirement fences #5655shared-agent-harness-3bb0-s7— feat(agent-harness): deliver legacy history and project durable text #5659shared-agent-harness-3bb0-s8— feat(agent-harness): authorize durable grants and registered clients #5662shared-agent-harness-3bb0-s9— feat(agent-harness): fence retirement and retry payload cleanup #5667shared-agent-harness-3bb0-s10— feat(agent-harness): persist authoritative state in SQLite #5675shared-agent-harness-3bb0-s11— feat(agent-harness): admit durable runs and revisioned commands #5678shared-agent-harness-3bb0-s12— feat(agent-harness): recover queued runs and stream checkpointed steps #5688shared-agent-harness-3bb0-s13— feat(agent-harness): resolve interactions and dispatch tools sequentially #5693shared-agent-harness-3bb0-s14— feat(agent-harness): fence designated client tool execution #5697shared-agent-harness-3bb0-s15— feat(agent-harness): synchronize durable snapshots and legacy history #5701shared-agent-harness-3bb0-s16— feat(agent-harness): reuse authorized invitations with durable replay #5704shared-agent-harness-3bb0-s17— feat(integrations): bound repository transport for harness reads #5710shared-agent-harness-3bb0-s18— feat(integrations): expose bounded authorized repository reads #5714shared-agent-harness-3bb0-s19— feat(agent-harness): expose named authorized resource reads #5718shared-agent-harness-3bb0-s20— feat(sessions): bound history transport for harness reads #5724shared-agent-harness-3bb0-s21— feat(agent-harness): read scoped Cloud Agent context and progress #5726 ← this PR (tip)