OpenCode v1.1.65#440
Conversation
…13222) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: LukeParkerDev <10430890+Hona@users.noreply.github.com> Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
…iption and parameters (#4956)
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| ) | ||
| log.debug("loaded custom config from KILO_CONFIG_CONTENT") | ||
| result = mergeConfigConcatArrays(result, JSON.parse(Flag.KILO_CONFIG_CONTENT)) | ||
| log.debug("loaded custom config from OPENCODE_CONFIG_CONTENT") |
There was a problem hiding this comment.
WARNING: Log message references OPENCODE_CONFIG_CONTENT but the env var is KILO_CONFIG_CONTENT. The old code correctly logged "loaded custom config from KILO_CONFIG_CONTENT" — this change introduces a misleading log message.
| log.debug("loaded custom config from OPENCODE_CONFIG_CONTENT") | |
| log.debug("loaded custom config from KILO_CONFIG_CONTENT") |
| await load(Flag.KILO_CONFIG_CONTENT, path.join(Instance.directory, "KILO_CONFIG_CONTENT")), | ||
| ) | ||
| log.debug("loaded custom config from KILO_CONFIG_CONTENT") | ||
| result = mergeConfigConcatArrays(result, JSON.parse(Flag.KILO_CONFIG_CONTENT)) |
There was a problem hiding this comment.
WARNING: JSON.parse() is called without error handling. If KILO_CONFIG_CONTENT contains malformed JSON, this will throw an unhandled exception and crash config loading entirely. The previous implementation routed through load() which likely had its own error handling.
Consider wrapping in a try/catch or validating the JSON before parsing.
| export const KILO_CONFIG = process.env["KILO_CONFIG"] | ||
| export declare const KILO_CONFIG_DIR: string | undefined | ||
| export declare const KILO_CONFIG_CONTENT: string | undefined | ||
| export const KILO_CONFIG_CONTENT = process.env["KILO_CONFIG_CONTENT"] |
There was a problem hiding this comment.
WARNING: This changes KILO_CONFIG_CONTENT from a dynamic getter (evaluated at access time) to a static const (evaluated at module load time). The removed Object.defineProperty block had a comment explaining: "This must be evaluated at access time, not module load time, because external tooling may set this env var at runtime."
If any external tooling (e.g., the desktop app or ACP) sets KILO_CONFIG_CONTENT after this module is first imported, the new value will not be picked up. Is this intentional?
| getWslEnabled: async () => { | ||
| const next = await commands.getWslConfig().catch(() => null) | ||
| if (next) return next.enabled | ||
| return window.__KILO__!.wsl ?? false |
There was a problem hiding this comment.
WARNING: window.__KILO__! uses a non-null assertion. If commands.getWslConfig() rejects (caught → returns null) and window.__KILO__ is undefined, this will throw a runtime TypeError. Consider using optional chaining instead:
| return window.__KILO__!.wsl ?? false | |
| return window.__KILO__?.wsl ?? false |
|
|
||
| onCleanup(() => { | ||
| active = false | ||
| listener.then((cb) => cb()) |
There was a problem hiding this comment.
SUGGESTION: The listener promise has no .catch() handler. If events.sqliteMigrationProgress.listen() rejects, this will produce an unhandled promise rejection during cleanup. Consider adding .catch(() => undefined) for safety:
| listener.then((cb) => cb()) | |
| listener.then((cb) => cb()).catch(() => undefined) |
Code Review SummaryStatus: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (20 files)
|
7 participants
Core
Revert token substitution in OPENCODE_CONFIG_CONTENT
Ensure @-mentioning a directory uses the read tool instead of deprecated list tool
Add tool.definition hook for plugins to modify tool description and parameters
Remove worktree delete functionality
Resolve ACP hanging indefinitely in thinking state on Windows
Desktop
Reconnect event stream on disconnect
Toggle all provider models in settings
Clean up desktop loading page
Notification should navigate to session
Fix prompt input behavior quirks
Failed to create store in app
Only show loading window if SQLite migration is necessary