[pull] master from getsentry:master#1608
Merged
pull[bot] merged 5 commits intoKingDEV95:masterfrom Jan 8, 2026
Merged
Conversation
#105828) A small tag length increase to fix an immediate bug where the `url` tag is not populated when it is too long. `256` is already the limit for the `request.url`, so we can just align these limits. Follow Ups: - Truncate tags instead of deleting them - Raise (double?) the limit further
…05640) This adds the workaround until v11 is out. At the moment we have to explicitly set `(env: Env) => ...` in order to make the types work. This can be reverted (no must) when following is merged and released: getsentry/sentry-javascript#18302 reference: getsentry/sentry-javascript#18294 (comment)
Additional metric `c:spans/count_segments_per_root_project@none` to
count segments span per root (not just spans).
- `has_transaction`/`was_transaction` tag to indicate whether the
(segment) span was created from a transaction and the transaction still
"exists". Added both because semantically it's not fully clear which
one(s) we're going to need.
- `is_segment` to indicate whether a span (e.g. in the usage metric) is
a segment
Usage has been checked:
```sql
SELECT string, count(*)
FROM sentry_{perf,}stringindexer
WHERE 1=1
AND string IN (
'c:spans/count_segments_per_root_project@none',
'has_transaction',
'was_transaction',
'is_segment'
)
GROUP BY string;
```
We need to modify `strings.py` as for DS we need to query the tags
across orgs, which is not possible if the indexer chooses the values.
Refs: INGEST-689
…ig (#105138) - We needed these logging statements for debugging in summer 2025 - We left them after the fix, in case something else would happen down the line - It is now clear that the problem is fixed, so we can remove the logging statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )