[pull] master from getsentry:master#1826
Merged
pull[bot] merged 1 commit intoKingDEV95:masterfrom Mar 26, 2026
Merged
Conversation
#109356) Migrate the organization sampling form from the bespoke `formContext`-based system to `useScrapsForm` from `@sentry/scraps/form`, following the same pattern already used in `samplingModeSwitchModal`. **What changed:** - `organizationSampling.tsx` — replaces `useFormState`/`FormProvider` from the custom context with `useScrapsForm`. The Zod schema is identical to the one in `samplingModeSwitchModal` (same field, same validation rules). `form.Subscribe` drives the Save/Reset button states reactively. After a successful save, `formApi.reset(value)` clears dirty state and a `savedTargetSampleRate` state variable tracks the last-saved value for the "previous: X%" display. - `projectsPreviewTable.tsx` — removes the `useFormField` context consumer and instead receives `targetSampleRate`, `savedTargetSampleRate`, `onTargetSampleRateChange`, and `targetSampleRateError` as explicit props. Exports `ProjectsPreviewTableProps` for use in the test mock. - `utils/organizationSamplingForm.tsx` — deleted; was the `createForm` wrapper for the custom context, now dead code. - `organizationSampling.spec.tsx` — new spec with 10 cases: initial value pre-fill, button enable/disable states, Zod validation errors, API payload, success flow (form resets + previous value updates), error flow (form stays dirty), reset behaviour, and access control. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Priscila Oliveira <priscila.oliveira@sentry.io>
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )