[pull] master from getsentry:master#1837
Merged
Merged
Conversation
before: <img width="1510" height="694" alt="CleanShot 2026-03-30 at 13 35 40@2x" src="https://github.com/user-attachments/assets/c8425aea-5d0c-42d2-8b98-40bab7ac3237" /> after: <img width="1512" height="682" alt="CleanShot 2026-03-30 at 13 36 50@2x" src="https://github.com/user-attachments/assets/cc5ab558-01a8-4399-9eee-047254148bc1" /> ## Summary Redesigns the snapshot page header (top-left section) with a cleaner layout: - **Title**: Changed from "Snapshots" to singular "Snapshot", removed breadcrumbs and feature badge - **VCS metadata row**: PR number, commit SHA, and branch name now display with proper icons (`IconPullRequest`, `IconCommit`, `IconStack`) and purple linked text - **Comparing row**: New "Comparing: **Head** vs **Base**" section for diff-mode snapshots - **Head** button toggles between diff and solo view (`?view=solo` query param) - **Base** button navigates to the base artifact's snapshot page - Both use pill-shaped buttons with accent-colored eye icons Uses Sentry design system components (`Button`, `LinkButton`, `Text`, `Flex`, `ExternalLink`) throughout. VCS items are rendered from a declarative config array for cleaner code. ## Test plan - [ ] Visit a snapshot page with diff comparison data (e.g. `/preprod/snapshots/169382/`) - [ ] Verify header shows "Snapshot" title, VCS info row with correct icons and purple links - [ ] Verify "Comparing" row appears with Head and Base pill buttons - [ ] Click Head → URL gets `?view=solo`, button turns primary (purple), content switches to solo view - [ ] Click Head again → returns to diff view - [ ] Click Base → navigates to base artifact's snapshot page - [ ] Verify VCS links (PR, commit, branch) open correct GitHub URLs - [ ] Visit a solo-mode snapshot (no base) → "Comparing" row should not appear
…111849) Also collect some metrics when each step completes to track success rates.
…efault agent for Autofix (#111366) Now people can pick which agent they want to send data to. The value cannot be empty, it's a preference for which agent will be used in automation, and which agent will be the default in the multi-agent dropdown when manually driving autofix. This change is behind a feature-flag, `seer-overview` while some related surfaces are also being updated. <img width="1007" height="251" alt="SCR-20260330-mxap" src="https://github.com/user-attachments/assets/0fdf71fc-f3d3-4e15-9fee-5f58e76b65d0" /> Fixes AIML-2618 --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
…111623) UI polish and analytics pass for the `SCM_PROJECT_DETAILS` onboarding step, matching the Figma designs and adding comprehensive event tracking. **UI changes:** - Use `ScmStepHeader` with step counter ("Step 3 of 3"), proper heading size (3xl), and subtitle - Fix content width from 600px to 506px (`SCM_STEP_CONTENT_WIDTH`) - Add section icons: `IconProject`, `IconGroup`, `IconSiren` - Use proper Figma typography tokens (`size="lg"`, `density="comfortable"`) - Replace `RadioGroup`-based `IssueAlertOptions` with new card-style `ScmAlertFrequency` component (bordered cards with selection state, icons, animated Custom expand) - Wire up real `useCreateNotificationAction` hook for "Connect to messaging" (replaces no-op) - Add `ScmStepFooter` and `LayoutGroup` animations - Add `busy` prop on Create button during project creation **Analytics (7 new events):** - `scm_project_details_step_viewed` — on mount - `scm_project_details_name_edited` — on blur, with `custom` flag - `scm_project_details_team_selected` — on change, with team slug - `scm_project_details_alert_selected` — on option change - `scm_project_details_create_clicked` — before API call - `scm_project_details_create_succeeded` — with project slug - `scm_project_details_create_failed` — on error **New component:** `ScmAlertFrequency` renders card-style radio options rather than modifying the shared `IssueAlertOptions` component, avoiding cross-cutting risk to the legacy project-creation page. Uses `Container border="accent"/"secondary"` pattern from `ScmFeatureCard`. Refs VDY-28
This adds a number of new test cases to our parameterization tests, covering negative numbers, more IP address formats, and different variations on "kitchen" time (time as it appears on a digital clock). Some represent successful parameterization, and some are cases we still need to fix.
This fixes two bugs with our "kitchen" (digital clock) time regex. - Allow 24-hour time to include leading zeros. - Restrict allowable values in each spot (no more 3-digit hours, no more minutes and seconds > 59, etc.).
github-actions
Bot
added
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )