[pull] master from getsentry:master#1998
Merged
Merged
Conversation
…6156) Removes the `padding: xl` (16px) from `BodyGrid` in the explore replays detail layout. **Before** Notice how the tabs on the right, "Trace" sticks out closer to the window edge compared to the table below it. <img width="1064" height="729" alt="SCR-20260525-sdow" src="https://github.com/user-attachments/assets/ee9cf77d-c3ac-4f7d-839c-c71b55f1e9b3" /> **After** This is consistent with the Issue Feed and other pages. Pages should not wrap their stuff with their own padding. <img width="1064" height="729" alt="SCR-20260525-sdpr" src="https://github.com/user-attachments/assets/c1f71f48-ddc5-4fa0-b781-fb3afb114831" /> Action taken on behalf of Ryan Albrecht. --- [View Session in Sentry](https://sentry.sentry.io/traces/?project=4510944073809921&query=gen_ai.conversation.id%3A%22slack%3AC0B63QA6RGA%3A1779769376.951799%22) Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
…mages (#115772) ## DESCRIBE YOUR PR Screen readers depend on **alt text** to describe images for people who can’t see them. On the issue details page, our browser/OS/device context icons were `<img>` elements with no `alt`, so screen readers weren't relaying useful information. This PR: - Adds descriptive `alt` text to context icons (for example, `os: macos`, `browser: chrome`) - Sets empty `alt=""` on decorative images so screen readers skip them ### Context Icons — before ```tsx // No alt attribute — screen readers fall back to the image filename <img height={size} width={size} css={extraCass} src={imageName} /> ``` ### Context Icons — after ```tsx // Falls back to `name` when no explicit alt is provided <img height={size} width={size} css={extraCass} src={imageName} alt={alt ?? name} /> ``` Call sites now pass a descriptive string: ```tsx <ContextIcon name={iconName} alt={`${type}: ${iconName}`} {...contextIconProps} /> ``` <img width="886" height="220" alt="Screenshot 2026-05-19 at 11 03 32 PM" src="https://github.com/user-attachments/assets/505bc5a5-67ca-4e09-b8c3-3762275e75fe" /> ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) --------- Co-authored-by: junior[bot] <junior[bot]@sentry.io> Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io> Co-authored-by: Ryan Albrecht <ryan@ryanalbrecht.ca>
…115988) ## Summary The loading row of the autofix Root Cause / Solution / Code Changes cards rendered the spinner partially cut off at the bottom while streaming was in progress. **Root cause:** the inner scroll container is constrained vertically by a parent flex ancestor to the spinner's intrinsic height (16px), and `overflow-y: auto` removes the flex `min-height: auto` protection that would normally keep the container at content height. The adjacent `<Text>` defaults to `line-height: 19.6px`, so the row's content was 3px taller than the container — `useAutoScroll` then scrolled by exactly that 3px and clipped the top of the spinner. **Fix:** set `density="compressed"` on the `<Text>` (line-height: 1), so the text's content box matches its font-size and the row fits within the container — no overflow scroll triggered. **Before** https://github.com/user-attachments/assets/798eb24c-75bd-4401-9548-84aebeb52cf1 **After** https://github.com/user-attachments/assets/82466e77-d299-45b5-96da-52b50467f570
| # | Replace | With | File |
| --- | --- | --- | --- |
| 1 | `HeaderImage` (styled img) | `<Image>` (wrapped in `<Container
display={{xs: 'none', sm: 'block'}}>` to preserve the small-screen hide)
| `onboarding.tsx` |
| 2 | `Divider` (styled hr, 95% width) | `<Container width="95%"
margin="0 auto"><Separator orientation="horizontal" /></Container>`
(wrapper preserves 95% width and centers it — also fixes a pre-existing
off-center bug) | `onboarding.tsx` |
| 3 | `DescriptionWrapper` (h4/h5/h6 typography resets) | `<Prose>` (and
raw `<p>` inside swapped for `<Text as="p">`) | `onboarding.tsx` |
| 4 | `CellExpander` (styled div, `width: 100vw`) | `<Container
width="100vw">` | `conversationsTable.tsx` |
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )