Skip to content

Force default bucket plugin only if necessary#380

Merged
leplatrem merged 2 commits intomasterfrom
force-include-if-necessary
Jan 26, 2016
Merged

Force default bucket plugin only if necessary#380
leplatrem merged 2 commits intomasterfrom
force-include-if-necessary

Conversation

@leplatrem
Copy link
Contributor

@Natim r?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we issue a warning and ask for it to be included in the configuration explicitely now?

@Natim
Copy link
Member

Natim commented Jan 20, 2016

I don't think people should include it in the config so IMHO we can let it as it is.

@leplatrem
Copy link
Contributor Author

I don't think people should include it in the config so IMHO we can let it as it is.

But that's the only way to have default bucket work with kinto-attachment ! And that's the main reason we put the default bucket as a plugin :) See #277

Should we issue a warning and ask for it to be included in the configuration explicitely now?

yes, I think so

@almet
Copy link
Member

almet commented Jan 20, 2016

Then, how do you remove the feature?

@Natim
Copy link
Member

Natim commented Jan 20, 2016

As far as I know we don't aim to make it an optional feature do we?

@leplatrem
Copy link
Contributor Author

Then, how do you remove the feature?

We cannot at this stage.

Currently the client of v1 expects the default bucket to create collections implicitly.

Being able to remove the default bucket could be part of the API v2.

@leplatrem leplatrem force-pushed the force-include-if-necessary branch from 7ab7769 to 6fe4b79 Compare January 21, 2016 15:18
@leplatrem
Copy link
Contributor Author

Ready to review/merge!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange to me to add it there if it is already added automatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that adding it automatically could be removed in 2.X, whereas config files can stay

@Natim
Copy link
Member

Natim commented Jan 26, 2016

r+

leplatrem added a commit that referenced this pull request Jan 26, 2016
Force default bucket plugin only if necessary
@leplatrem leplatrem merged commit 717fa62 into master Jan 26, 2016
@leplatrem leplatrem deleted the force-include-if-necessary branch January 26, 2016 15:33
@leplatrem leplatrem modified the milestone: 1.11.0 Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants