Fix silent save failures and list crash on fresh clone - #9
Merged
Conversation
Ensure the secret/ directory is created before opening the database
or writing password files, so a fresh clone (where secret/ is
gitignored) does not fail.
- commands/add.py: os.makedirs('./secret', exist_ok=True) before
sqlite3.connect, so save (opt 1) no longer silently fails and
list (opt 2) no longer crashes with 'unable to open database file'.
- japanese/commands/add.py: same guard before writing password files.
Closes #8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8
On a fresh clone,
secret/is gitignored and never created, so:commands/add.pyopenssqlite3.connect("./secret/passwords.db")without the directory existing, and the bareexcept Exceptionswallows the error, printingError: unable to open database fileand returning success.sqlite3.OperationalError: unable to open database filebecause the connect happens outside any try/except.Change
Create the
secret/directory before writing to it:commands/add.py:os.makedirs("./secret", exist_ok=True)beforesqlite3.connectso save no longer silently fails and list finds the DB.japanese/commands/add.py: same guard before writing password files to./secret/.