Merged
Conversation
6 tasks
…hout changing a default form
This ensures we don’t save tokens from another Plugin that uses a different client ID.
…lient-id v4 API: Refresh Tokens: Check Client ID
…egacy-form v4 API: Support Adding Subscribers to Legacy Forms
…i' into v4-api-oauth-setup-wizard # Conflicts: # admin/setup-wizard/class-convertkit-admin-setup-wizard-plugin.php # composer.json
v4 API: Setup Wizard
# Conflicts: # includes/class-convertkit-ajax.php # includes/class-convertkit-setup.php # tests/acceptance/tags/PageTagCest.php # wp-convertkit.php
…dynamic-redirect-uri # Conflicts: # includes/class-convertkit-ajax.php
…-uri v4 API: OAuth: Change Redirect URI
v4 API: Tag Subscriber Logic
v4 API: Show OAuth Errors
v4 API: Use ConvertKit-hosted redirect URI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the API Key and Secret fields with the OAuth flow using the v4 API at
Settings > ConvertKit, using the v4 API library implementation for API requests.Before:
After:
Video:
https://www.loom.com/share/e5f412bbf9954bb6bbd8ad367a4ce20f?sid=2cd70890-aadb-4faf-9d1b-bc0d8ae2e804
Testing
Some tests will currently fail due to changes in the UI for OAuth, Setup Wizard and Legacy Forms / Landing Pages.
Further PR's submitted for ease of review to cover these separately:
With those PR's merged, tests here must then pass.
Checklist