v4 API: Exchange API Key and Secret for Access and Refresh Tokens on Plugin Upgrade#656
Merged
n7studios merged 13 commits intov4-api-oauth-testsfrom May 17, 2024
Merged
Conversation
…exchange-key-for-token
…exchange-key-for-token # Conflicts: # includes/class-convertkit-setup.php
…exchange-key-for-token
…oauth-exchange-key-for-token
…oauth-exchange-key-for-token
…oauth-exchange-key-for-token
noelherrick
approved these changes
May 15, 2024
Contributor
noelherrick
left a comment
noelherrick
left a comment
There was a problem hiding this comment.
In the method name, the word exchange seems to imply that you are getting rid of the old auth credentials, which you are not, so perhaps lookup_access_token_by_api_secret would be better?
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatically exchanges an existing Plugin installation's API Key and Secret for Access and Refresh Tokens when the Plugin is upgraded to
2.5.0or higher, which introduces using the v4 API with OAuth.Testing
testExchangeAPIKeyAndSecretForAccessToken: Tests that an existing Plugin installation's API Key and Secret are exchanged for Access and Refresh Tokens, which are then tested as working by making API calls through loading the Plugin's settings screen.Checklist