Bump tokio-tungstenite from 0.24.0 to 0.28.0#1438
Conversation
| @@ -2138,7 +2138,7 @@ dependencies = [ | |||
| "libc", | |||
| "percent-encoding", | |||
| "pin-project-lite", | |||
| "socket2 0.6.1", | |||
| "socket2 0.5.9", | |||
| "tokio", | |||
| "tower-service", | |||
| "tracing", | |||
| @@ -2639,7 +2639,7 @@ dependencies = [ | |||
| "tempfile", | |||
| "thiserror 2.0.17", | |||
| "tokio", | |||
| "tokio-tungstenite 0.28.0", | |||
| "tokio-tungstenite", | |||
| "toml 0.9.10+spec-1.1.0", | |||
| "tower-lsp", | |||
| "ts-rs", | |||
| @@ -3212,7 +3212,7 @@ version = "0.50.3" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "7957b9740744892f114936ab4a57b3f487491bbeafaf8083688b16841a4240e5" | |||
| dependencies = [ | |||
| "windows-sys 0.61.1", | |||
| "windows-sys 0.59.0", | |||
| ] | |||
|
|
|||
| [[package]] | |||
| @@ -4493,7 +4493,7 @@ dependencies = [ | |||
| "errno", | |||
| "libc", | |||
| "linux-raw-sys 0.11.0", | |||
| "windows-sys 0.61.1", | |||
| "windows-sys 0.59.0", | |||
| ] | |||
|
|
|||
| [[package]] | |||
| @@ -5353,7 +5353,7 @@ dependencies = [ | |||
| "getrandom 0.3.2", | |||
| "once_cell", | |||
| "rustix 1.1.3", | |||
| "windows-sys 0.61.1", | |||
| "windows-sys 0.59.0", | |||
| ] | |||
|
|
|||
| [[package]] | |||
| @@ -5362,7 +5362,7 @@ version = "1.2.0" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "2111ef44dae28680ae9752bb89409e7310ca33a8c621ebe7b106cf5c928b3ac0" | |||
| dependencies = [ | |||
| "windows-sys 0.61.1", | |||
| "windows-sys 0.59.0", | |||
There was a problem hiding this comment.
Dependency Downgrade Issue: Upgrading tokio-tungstenite from 0.24.0 to 0.28.0 is causing multiple transitive dependencies to be downgraded:
windows-sys: 0.61.1 → 0.59.0 (downgrade)socket2: 0.6.1 → 0.5.9 (downgrade)
This is highly unusual for a forward version upgrade and suggests a dependency resolution problem. Downgrading dependencies can:
- Reintroduce fixed bugs or security vulnerabilities
- Remove features that other parts of the codebase may rely on
- Cause runtime incompatibilities
Fix: The Cargo.lock file should be regenerated properly:
cargo clean
cargo update -p tokio-tungstenite
cargo buildIf the downgrades persist, investigate dependency conflicts by running:
cargo tree -i windows-sys
cargo tree -i socket2This will show which packages are forcing the older versions and may indicate incompatibilities that need to be resolved.
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
642ba26 to
dd3c012
Compare
dd3c012 to
b9a881d
Compare
|
@dependabot recreate |
Bumps [tokio-tungstenite](https://github.com/snapview/tokio-tungstenite) from 0.24.0 to 0.28.0. - [Changelog](https://github.com/snapview/tokio-tungstenite/blob/master/CHANGELOG.md) - [Commits](snapview/tokio-tungstenite@v0.24.0...v0.28.0) --- updated-dependencies: - dependency-name: tokio-tungstenite dependency-version: 0.28.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
b9a881d to
35dc419
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
=======================================
Coverage 69.27% 69.27%
=======================================
Files 41 41
Lines 6769 6769
=======================================
Hits 4689 4689
Misses 2080 2080
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bumps tokio-tungstenite from 0.24.0 to 0.28.0.
Changelog
Sourced from tokio-tungstenite's changelog.
Commits
35d110cImplement into_inner to get the underlying stream (#367)f3ae75dUpdatetungsteniteversion and fix bugs25b544eAllow getting a reference to the shared inner stream (#363)e855f9eFix errors in the examples caused byUtf8Error21c5d19Bump versionfbd1471Update performance notes in READMEa8d9f19Bump versionaafb2f9Bump version0eefa27Bump version2d23077Update to newtungsteniteand bump versionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)