Skip to content

Report global errors#505

Merged
floryst merged 2 commits intomainfrom
report-global-errors
Nov 15, 2023
Merged

Report global errors#505
floryst merged 2 commits intomainfrom
report-global-errors

Conversation

@floryst
Copy link
Copy Markdown
Contributor

@floryst floryst commented Nov 13, 2023

  • Adds a call to captureException on global errors
  • Fixes reportingEnabled not being reactive

@floryst floryst requested a review from PaulHax November 13, 2023 17:27
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 13, 2023

Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit e9dd799
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/65525c88a5b1640008792538
😎 Deploy Preview https://deploy-preview-505--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Batten down hatches for error storm... hopefully?

@floryst
Copy link
Copy Markdown
Contributor Author

floryst commented Nov 15, 2023

LGTM. Batten down hatches for error storm... hopefully?

Get ready for all of the sentry errors :)

@floryst floryst added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 0d95bcb Nov 15, 2023
@floryst floryst deleted the report-global-errors branch March 21, 2024 16:26
PaulHax pushed a commit to PaulHax/VolView that referenced this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants