Skip to content

Report global errors #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
floryst merged 2 commits into from
Nov 15, 2023
+12 −7
Merged

Report global errors #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6392ee
feat(useGlobalErrorHook): report errors
floryst Nov 13, 2023
e9dd799
refactor(DataSecurityBox): reactive state
floryst Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/DataSecurityBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ import {
errorReportingConfigured,
useErrorReporting,
} from '@/src/utils/errorReporting';
import { watch, ref } from 'vue';
import { computed } from 'vue';

const errorStore = useErrorReporting();
const reportingEnabled = ref(!errorStore.disableReporting);
watch(reportingEnabled, (enabled) => {
errorStore.disableReporting = !enabled;
const reportingEnabled = computed({
get: () => !errorStore.disableReporting,
set: (enabled) => {
errorStore.disableReporting = !enabled;
},
});
</script>

Expand Down
9 changes: 6 additions & 3 deletions src/composables/useGlobalErrorHook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
import { onBeforeUnmount, onMounted } from 'vue';
import { captureException } from '@sentry/vue';
import { useMessageStore } from '../store/messages';

export function useGlobalErrorHook() {
const messageStore = useMessageStore();

const onError = (event: ErrorEvent) => {
console.error(event);
const details = event.error
? event.error
: { details: event.message ?? 'Unknown error' };
const errorMessage = event.message ?? 'Unknown global error';

captureException(event.error ?? errorMessage);

const details = event.error ? event.error : { details: errorMessage };
messageStore.addError('Application error (click for details)', details);
};

Expand Down