Schema/refresh phase2#516
Merged
Merged
Conversation
Closed
BryonLewis
requested changes
Dec 31, 2020
Collaborator
BryonLewis
left a comment
There was a problem hiding this comment.
Big PR and seems fully functional on Linux at least. Went through most of the standards of testing the loading, swapping, running pipelines and others for the electron version. I also tested to make sure the changes to loading meta/detections didn't have any adverse effect on the server. All seems stable. I didn't worry about windows testing as of this moment.
Most of what I have are just my standard annoying questions and wondering where stuff is heading towards. I do think we shouldn't do the moving of track.json in source media folder and instead do a copy.
BryonLewis
approved these changes
Jan 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2: what really happened.
Phase 2 went differently than I expected. I doubled back on some choices from Phase 1, and it turned out less involved than I originally thought, so rather than try to make a bunch of changes in 1, then roll them back in 2, I'd prefer to just review 2 as if it were the only change. This will close #515
loadDetections/loadMetadatainstead ofloadDataset. There was no need to remove the decoupling between these methods. I was wrong that detections requires metadata: it only actually requires knowlege of the base data path. Extra reasoning is explaining inline in a comment indesktop/frontend/store/index.tsdesktop/frontendanddesktop/backendfor clarity.SaveDetectionArgssince the object provided no benefit over a simpler array. This involves a simple server-side change.Not included
Persistence for job run history (logs will not be populated if a job is loaded from this storage area)
Error handling for importMedia issues. Right now they just dump to console and nothing happens in the UI.
Error handling for when source files change location.
In this sense, this is more of a phase 1.5.
Some notes on the size of the changes
The size of this PR is misleading. I renamed some files (most notably
frontend/api.ts) and reordered the contents. Many other files have been renamed, and git is considering them 100% changed for some reason.It's probably closer to 850+, 500-