Skip to content

Conversation

@FezVrasta
Copy link
Contributor

fixes #40

@jourdain
Copy link
Collaborator

jourdain commented Oct 10, 2021

@xhlulu what do you think? This is going to affect how dash-vtk is building against it. It should not be too much trouble to update it, but I wanted to have your thought on it. So far we were using the UMD build, but with that change only cjs and esm will be available.

@FezVrasta, we were using the UMD in dash-vtk to get a single file dependency. But we might be able to use cjs instead.

@xhluca
Copy link

xhluca commented Oct 10, 2021

I'm not familiar with JS bundling, so I'll let Alex J decide here :)

@FezVrasta
Copy link
Contributor Author

I can add the UMD bundle back as a separate Rollup build if the existing UMD is required

@FezVrasta
Copy link
Contributor Author

I restored the UMD target.

@FezVrasta FezVrasta changed the title fix ESM dist and remove UMD bundle fix ESM dist target Oct 11, 2021
@FezVrasta FezVrasta force-pushed the fix-esm branch 2 times, most recently from b9e110d to d8a80d0 Compare October 11, 2021 06:27
@jourdain jourdain merged commit b1dc18c into Kitware:master Oct 11, 2021
@jourdain
Copy link
Collaborator

🎉 This PR is included in version 1.8.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not ship node_modules folder with package

3 participants