Added focalPoint as prop and setting on update - #66
Merged
floryst merged 1 commit intoJul 19, 2022
Conversation
Contributor
Author
|
Not sure why we need to call cameraReset every positional update but I tried to keep everything the same. Have concern on moving the order of operation to resetCamera and then setCamera, but if my logic is correct, the only difference should be focalPoint is retained. |
floryst
reviewed
May 31, 2022
floryst
reviewed
May 31, 2022
floryst
force-pushed
the
feature/focalpoint_prop
branch
3 times, most recently
from
July 15, 2022 16:10
abf2895 to
4b789a2
Compare
floryst
force-pushed
the
feature/focalpoint_prop
branch
from
July 19, 2022 16:42
4b789a2 to
ce8c428
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
Added focalPoint as prop and setting on update 769c19b
Collaborator
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: focalPoint is reset due to resetCamera call for each position update.
I added focalPoint as prop, and setting it after resetCamera, to retain focalpoint.
line 465
if (previous) { this.resetCamera(); }