Add after subset queue hook and example how to use JUnit formatter in Queue Mode#41
Merged
Add after subset queue hook and example how to use JUnit formatter in Queue Mode#41
Conversation
This was referenced May 22, 2017
ArturT
force-pushed
the
queue-hooks
branch
2 times, most recently
from
dd360d7 to
342f4c4
Compare
bobbytables
reviewed
May 23, 2017
|
|
||
| def after_subset_queue(&block) | ||
| @after_subset_queue ||= block | ||
| end |
There was a problem hiding this comment.
This solution would at least allow us to rename the file that we output the results to. So I think this is actually a fine solution. Because in our spec_helper.rb we can do:
KnapsackPro::Hooks::Queue.after_subset_queue do |queue_id, subset_queue_id|
FileUtils.mv('tmp/rspec.xml', "tmp/rspec_#{SecureRandom.hex(10)}.xml")
end
Member
Author
There was a problem hiding this comment.
Yep, I tried that here https://github.com/KnapsackPro/rails-app-with-knapsack_pro/pull/6/files but there is another problem described here #40 (comment)
ArturT
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue: #40
Here is example of hook usage: KnapsackPro/rails-app-with-knapsack_pro#6