Conversation
after the rspec is called so it won’t work here. We need to call hook within the RSpec before context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a way to defined before queue hook and after queue hook in Knapsack Pro Queue Mode.
Context:
RSpec.before(:suite)so you have access to whatever method RSpec provides.RSpec.after(:suite)context due to the fact we know when the queue is ended only when all tests fetched from Knapsack Pro API are executed hence we are not able to defineRSpec.after(:suite)before the last run of a subset of tests from the work queue because we don't know which subset will be the last one.Here is related PR with after subset queue hook: #41
Here is monkey patch fix done by Joel that was inspiration to add hooks https://gist.github.com/jturkel/20d12d47ad4cf3e8e111ff318dd5a09a