Skip to content

fix(backend): Explicitly whitelist reported frontend origin in CORS config#25

Open
KnellBalm wants to merge 2 commits intomainfrom
fix-cors-origin-16649199408041380953
Open

fix(backend): Explicitly whitelist reported frontend origin in CORS config#25
KnellBalm wants to merge 2 commits intomainfrom
fix-cors-origin-16649199408041380953

Conversation

@KnellBalm
Copy link
Copy Markdown
Owner

@KnellBalm KnellBalm commented Jan 31, 2026

The user reported a CORS error for 'https://query-craft-frontend-758178119666.us-central1.run.app'. Although this origin was covered by the regex and the list, we explicitly re-added it to the list to ensure no subtle issues (e.g. invisible characters) and to force a redeployment of the backend service to ensure the latest configuration is active. Verified with local reproduction script and existing tests.


PR created automatically by Jules for task 16649199408041380953 started by @KnellBalm

Summary by Sourcery

Bug Fixes:

  • Ensure the reported Cloud Run frontend origin is explicitly allowed in the CORS origin whitelist to prevent CORS errors.

…onfig

Co-authored-by: KnellBalm <90038472+KnellBalm@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jan 31, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates backend CORS configuration to explicitly whitelist the reported Cloud Run frontend origin, adding a clarifying comment without changing runtime behavior beyond ensuring the origin is clearly allowed and triggering redeploy.

Sequence diagram for CORS preflight with explicit frontend origin

sequenceDiagram
    actor User
    participant Browser
    participant Frontend_CloudRun as Frontend_CloudRun
    participant Backend_CloudRun as Backend_CloudRun

    User->>Browser: Open app URL
    Browser->>Frontend_CloudRun: Load frontend (HTML, JS)
    Frontend_CloudRun-->>Browser: Frontend assets

    Browser->>Backend_CloudRun: OPTIONS /api (Origin: reported_frontend_origin)
    Backend_CloudRun->>Backend_CloudRun: Check Origin against cloud_origins list
    Backend_CloudRun-->>Browser: CORS headers (Access_Control_Allow_Origin: reported_frontend_origin)

    Browser->>Backend_CloudRun: Actual API request (e.g. GET /api)
    Backend_CloudRun-->>Browser: API response
    Browser-->>User: Render data without CORS error
Loading

File-Level Changes

Change Details Files
Explicitly whitelist the reported frontend Cloud Run origin in the CORS allowed-origins list and clarify its purpose.
  • Keep the existing problematic origin string in the cloud_origins allowlist while adding an inline comment indicating it is the reported issue origin
  • Remove the outdated or redundant comment from the subsequent Cloud Run origin entry to keep comments focused and clear
backend/main.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Co-authored-by: KnellBalm <90038472+KnellBalm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant