Skip to content

fix(backend): Explicitly whitelist reported frontend origin in CORS config #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KnellBalm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(backend): Explicitly whitelist reported frontend origin in CORS config #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cff3c1
fix(backend): Explicitly whitelist reported frontend origin in CORS c…
google-labs-jules[bot] Jan 31, 2026
d87080e
test(backend): Fix integration test config for CI environment
google-labs-jules[bot] Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ def start_scheduler_background():
# Cloud Run 도메인 및 Regex 정의 (환경 무관하게 참조 가능하도록)
cloud_origins = [
"https://query-craft-frontend-53ngedkhia-uc.a.run.app",
"https://query-craft-frontend-758178119666.us-central1.run.app",
"https://query-craft-frontend-758178119666.a.run.app", # 추가
"https://query-craft-frontend-758178119666.us-central1.run.app", # Reported issue origin
"https://query-craft-frontend-758178119666.a.run.app",
"https://querycraft.run.app", # 커스텀 도메인 예비
]
# 좀 더 유연한 regex: query-craft-frontend로 시작하는 모든 .run.app 도메인 허용
Expand Down
2 changes: 2 additions & 0 deletions tests/test_cors_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
from fastapi.testclient import TestClient

# Set ENV to production before importing backend.main to ensure production CORS settings are used
# Also set POSTGRES_DSN to a dummy value to pass the production config check
os.environ["ENV"] = "production"
os.environ["POSTGRES_DSN"] = "postgresql://user:pass@localhost:5432/db"

try:
from backend.main import app
Expand Down